[ovs-dev] [PATCH] odp-util: Fix another hang in NSH action parsing.

[Ben Pfaff]

You're welcome.

I applied this to master and branch-2.8.

On Thu, Nov 30, 2017 at 02:55:53PM +0000, Jan Scheurich wrote:
> Good spot. Thanks for fixing this!
> 
> Acked-by: Jan Scheurich <jan.scheurich at ericsson.com>
> 
> > -----Original Message-----
> > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-bounces at openvswitch.org] On Behalf Of Ben Pfaff
> > Sent: Wednesday, 29 November, 2017 17:59
> > To: dev at openvswitch.org
> > Cc: Ben Pfaff <blp at ovn.org>; Bhargava Shastry <bshastry at sec.t-labs.tu-berlin.de>
> > Subject: [ovs-dev] [PATCH] odp-util: Fix another hang in NSH action parsing.
> > 
> > Found by libfuzzer.
> > 
> > Reported-by: Bhargava Shastry <bshastry at sec.t-labs.tu-berlin.de>
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> >  lib/odp-util.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/odp-util.c b/lib/odp-util.c
> > index 3e30b9ae7719..23d5a01b3bc7 100644
> > --- a/lib/odp-util.c
> > +++ b/lib/odp-util.c
> > @@ -1867,8 +1867,8 @@ parse_odp_encap_nsh_action(const char *s, struct ofpbuf *actions)
> >                  }
> >                  encap_nsh.mdlen = mdlen + padding;
> >                  ofpbuf_uninit(&b);
> > +                continue;
> >              }
> > -            continue;
> >          }
> > 
> >          return -EINVAL;
> > --
> > 2.10.2
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev