[ovs-dev] [PATCH] sflow: Correctly document setup command.

Gregory Rose gvrose8192 at gmail.com
Mon Dec 4 16:32:28 UTC 2017


On 11/30/2017 10:38 AM, Ben Pfaff wrote:
> Reported-by: Shivaram Mysore <shivaram.mysore at gmail.com>
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>   Documentation/howto/sflow.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/howto/sflow.rst b/Documentation/howto/sflow.rst
> index 1152a7db567a..66f4856b3340 100644
> --- a/Documentation/howto/sflow.rst
> +++ b/Documentation/howto/sflow.rst
> @@ -105,7 +105,7 @@ Still on `host1`, run the following command to create an sFlow configuration
>   and attach it to bridge br0::
>   
>       $ ovs-vsctl -- --id=@sflow create sflow agent=${AGENT_IP} \
> -        target="${COLLECTOR_IP}:${COLLECTOR_PORT}" header=${HEADER_BYTES} \
> +        target='"${COLLECTOR_IP}:${COLLECTOR_PORT}"' header=${HEADER_BYTES} \
>           sampling=${SAMPLING_N} polling=${POLLING_SECS} \
>             -- set bridge br0 sflow=@sflow
>   

Looks good.

Reviewed-by: Greg Rose <gvrose8192 at gmail.com>



More information about the dev mailing list