[ovs-dev] [PATCH v3 6/6] netdev-linux: fail ops not supporting remote netns.
Flavio Leitner
fbl at redhat.com
Thu Dec 7 02:22:24 UTC 2017
When the netdev is in another namespace and the operation doesn't
support network namespaces, return the correct error.
Signed-off-by: Flavio Leitner <fbl at redhat.com>
---
lib/netdev-linux.c | 134 +++++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 120 insertions(+), 14 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index c23e0f33c..74107d044 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -1340,6 +1340,11 @@ netdev_linux_send(struct netdev *netdev_, int qid OVS_UNUSED,
int sock = 0;
if (!is_tap_netdev(netdev_)) {
+ if (netdev_linux_netnsid_is_remote(netdev_linux_cast(netdev_))) {
+ error = EOPNOTSUPP;
+ goto free_batch;
+ }
+
sock = af_packet_sock();
if (sock < 0) {
error = -sock;
@@ -1399,6 +1404,10 @@ netdev_linux_set_etheraddr(struct netdev *netdev_, const struct eth_addr mac)
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
if (netdev->cache_valid & VALID_ETHERADDR) {
error = netdev->ether_addr_error;
@@ -1512,6 +1521,11 @@ netdev_linux_set_mtu(struct netdev *netdev_, int mtu)
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
if (netdev->cache_valid & VALID_MTU) {
error = netdev->netdev_mtu_error;
if (error || netdev->mtu == mtu) {
@@ -1541,9 +1555,14 @@ netdev_linux_get_ifindex(const struct netdev *netdev_)
int ifindex, error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
error = get_ifindex(netdev_, &ifindex);
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error ? -error : ifindex;
}
@@ -2084,6 +2103,11 @@ netdev_linux_get_features(const struct netdev *netdev_,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
netdev_linux_read_features(netdev);
if (!netdev->get_features_error) {
*current = netdev->current;
@@ -2092,8 +2116,9 @@ netdev_linux_get_features(const struct netdev *netdev_,
*peer = 0; /* XXX */
}
error = netdev->get_features_error;
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2109,6 +2134,12 @@ netdev_linux_set_advertisements(struct netdev *netdev_,
ovs_mutex_lock(&netdev->mutex);
COVERAGE_INC(netdev_get_ethtool);
+
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
memset(&ecmd, 0, sizeof ecmd);
error = netdev_linux_do_ethtool(netdev_get_name(netdev_), &ecmd,
ETHTOOL_GSET, "ETHTOOL_GSET");
@@ -2186,6 +2217,11 @@ netdev_linux_set_policing(struct netdev *netdev_,
: kbits_burst); /* Stick with user-specified value. */
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto out;
+ }
+
if (netdev->cache_valid & VALID_POLICING) {
error = netdev->netdev_policing_error;
if (error || (netdev->kbits_rate == kbits_rate &&
@@ -2322,6 +2358,11 @@ netdev_linux_get_qos(const struct netdev *netdev_,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (!error) {
*typep = netdev->tc->ops->ovs_name;
@@ -2329,8 +2370,9 @@ netdev_linux_get_qos(const struct netdev *netdev_,
? netdev->tc->ops->qdisc_get(netdev_, details)
: 0);
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2352,6 +2394,11 @@ netdev_linux_set_qos(struct netdev *netdev_,
}
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (error) {
goto exit;
@@ -2385,6 +2432,11 @@ netdev_linux_get_queue(const struct netdev *netdev_,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (!error) {
struct tc_queue *queue = tc_find_queue(netdev_, queue_id);
@@ -2392,8 +2444,9 @@ netdev_linux_get_queue(const struct netdev *netdev_,
? netdev->tc->ops->class_get(netdev_, queue, details)
: ENOENT);
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2405,6 +2458,11 @@ netdev_linux_set_queue(struct netdev *netdev_,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (!error) {
error = (queue_id < netdev->tc->ops->n_queues
@@ -2412,8 +2470,9 @@ netdev_linux_set_queue(struct netdev *netdev_,
? netdev->tc->ops->class_set(netdev_, queue_id, details)
: EINVAL);
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2424,6 +2483,11 @@ netdev_linux_delete_queue(struct netdev *netdev_, unsigned int queue_id)
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (!error) {
if (netdev->tc->ops->class_delete) {
@@ -2435,8 +2499,9 @@ netdev_linux_delete_queue(struct netdev *netdev_, unsigned int queue_id)
error = EINVAL;
}
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2449,6 +2514,11 @@ netdev_linux_get_queue_stats(const struct netdev *netdev_,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (!error) {
if (netdev->tc->ops->class_get_stats) {
@@ -2464,8 +2534,9 @@ netdev_linux_get_queue_stats(const struct netdev *netdev_,
error = EOPNOTSUPP;
}
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2508,10 +2579,15 @@ struct netdev_linux_queue_state {
static int
netdev_linux_queue_dump_start(const struct netdev *netdev_, void **statep)
{
- const struct netdev_linux *netdev = netdev_linux_cast(netdev_);
+ struct netdev_linux *netdev = netdev_linux_cast(netdev_);
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (!error) {
if (netdev->tc->ops->class_get) {
@@ -2532,8 +2608,9 @@ netdev_linux_queue_dump_start(const struct netdev *netdev_, void **statep)
error = EOPNOTSUPP;
}
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2541,11 +2618,16 @@ static int
netdev_linux_queue_dump_next(const struct netdev *netdev_, void *state_,
unsigned int *queue_idp, struct smap *details)
{
- const struct netdev_linux *netdev = netdev_linux_cast(netdev_);
+ struct netdev_linux *netdev = netdev_linux_cast(netdev_);
struct netdev_linux_queue_state *state = state_;
int error = EOF;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
while (state->cur_queue < state->n_queues) {
unsigned int queue_id = state->queues[state->cur_queue++];
struct tc_queue *queue = tc_find_queue(netdev_, queue_id);
@@ -2556,8 +2638,9 @@ netdev_linux_queue_dump_next(const struct netdev *netdev_, void *state_,
break;
}
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2580,6 +2663,11 @@ netdev_linux_dump_queue_stats(const struct netdev *netdev_,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = tc_query_qdisc(netdev_);
if (!error) {
struct queue_dump_state state;
@@ -2606,8 +2694,9 @@ netdev_linux_dump_queue_stats(const struct netdev *netdev_,
}
}
}
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2619,6 +2708,11 @@ netdev_linux_set_in4(struct netdev *netdev_, struct in_addr address,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = do_set_addr(netdev_, SIOCSIFADDR, "SIOCSIFADDR", address);
if (!error) {
if (address.s_addr != INADDR_ANY) {
@@ -2627,8 +2721,8 @@ netdev_linux_set_in4(struct netdev *netdev_, struct in_addr address,
}
}
+exit:
ovs_mutex_unlock(&netdev->mutex);
-
return error;
}
@@ -2643,9 +2737,15 @@ netdev_linux_get_addr_list(const struct netdev *netdev_,
int error;
ovs_mutex_lock(&netdev->mutex);
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
+
error = netdev_get_addrs(netdev_get_name(netdev_), addr, mask, n_cnt);
- ovs_mutex_unlock(&netdev->mutex);
+exit:
+ ovs_mutex_unlock(&netdev->mutex);
return error;
}
@@ -2886,6 +2986,10 @@ netdev_linux_update_flags(struct netdev *netdev_, enum netdev_flags off,
ovs_mutex_lock(&netdev->mutex);
if (on || off) {
/* Changing flags over netlink isn't support yet. */
+ if (netdev_linux_netnsid_is_remote(netdev)) {
+ error = EOPNOTSUPP;
+ goto exit;
+ }
error = update_flags(netdev, off, on, old_flagsp);
} else {
/* Try reading flags over netlink, or fall back to ioctl. */
@@ -2895,6 +2999,8 @@ netdev_linux_update_flags(struct netdev *netdev_, enum netdev_flags off,
error = update_flags(netdev, off, on, old_flagsp);
}
}
+
+exit:
ovs_mutex_unlock(&netdev->mutex);
return error;
}
--
2.14.3
More information about the dev
mailing list