[ovs-dev] [PATCH v6 0/4] nsh: add new nsh key ttl and action dec_nsh_ttl

[Gregory Rose]

On 12/8/2017 6:04 AM, Yi Yang wrote:
> v5->v6
>    - Rebase v5 to master
>    - Refactor netlink message format to align to NSH kernel
>      implementation
>    - Add dec_nsh_ttl unit test into tests/nsh.at
>    - Fix unit test unstable issue
>
> v4->v5
>    - Remove fix patch 1 in v4 because it is merged
>    - Fix several comments by Jan Scheurich
>
> v3->v4
>    - Add new action dec_nsh_ttl
>    - Remove encap_nsh and decap_nsh changes
>    - Remove netlink rework to adapt to OVS 2.8
>    - Dynamically allocate struct ovs_action_encap_nsh and put
>      appropriate size for ENCAP_NSH netlink message.
>
> v2->v3
>    - Fix several comments Jan Scheurich
>
> v1->v2
>    - Rework per kernel datapath review comments
>    - Add new NSH key ttl
>    - Add many helpers in nsh.h and replace much code
>      with these helpers
>    - nsh.h includes the lasted NSH spec
>    - bits of flags and mdtype have a change
>
> This patch refactored NSH netlink keys, push_nsh action
>   and netlink message format to align to NSH kernel
> implementation. It also adds new NSH key 'ttl' and a new
> action dec_nsh_ttl to follow the lasted IETF NSH draft:
>
> https://datatracker.ietf.org/doc/draft-ietf-sfc-nsh/
>
>
> Yi Yang (4):
>    nsh: rework NSH netlink keys and actions
>    nsh: add new flow key 'ttl'
>    nsh: fix nested mask for OVS_KEY_ATTR_NSH
>    nsh: add dec_nsh_ttl action
>
>   datapath/linux/compat/include/linux/openvswitch.h |  58 +-
>   include/openvswitch/flow.h                        |   6 +-
>   include/openvswitch/meta-flow.h                   |  31 +-
>   include/openvswitch/nsh.h                         | 122 +++-
>   include/openvswitch/ofp-actions.h                 |   1 +
>   include/openvswitch/packets.h                     |   9 +-
>   lib/dpif-netdev.c                                 |   4 +-
>   lib/dpif.c                                        |   4 +-
>   lib/flow.c                                        |  61 +-
>   lib/flow.h                                        |   2 +-
>   lib/match.c                                       |  24 +-
>   lib/meta-flow.c                                   |  69 +-
>   lib/meta-flow.xml                                 |   6 +-
>   lib/nx-match.c                                    |  20 +-
>   lib/odp-execute.c                                 |  82 ++-
>   lib/odp-util.c                                    | 830 +++++++++++++++++-----
>   lib/odp-util.h                                    |   5 +
>   lib/ofp-actions.c                                 |  49 ++
>   lib/packets.c                                     |  27 +-
>   lib/packets.h                                     |   5 +-
>   ofproto/ofproto-dpif-ipfix.c                      |   4 +-
>   ofproto/ofproto-dpif-sflow.c                      |   4 +-
>   ofproto/ofproto-dpif-xlate.c                      |  62 +-
>   tests/nsh.at                                      |  63 +-
>   utilities/ovs-ofctl.8.in                          |  13 +-
>   25 files changed, 1160 insertions(+), 401 deletions(-)
>

I don't see any backport of the upstream kernel datapath changes? I'm 
working on catching our out of tree datapath code with the upstream 
Linux kernel datapath and your patch (commit 
b2d0f5d5dc53532e6f07bc546a476a55ebdfe0f3 " openvswitch: enable NSH 
support") needs the backport as well as compat layer changes.

Do you plan on doing that work?

Thanks,

- Greg