[ovs-dev] [PATCH 1/2] test-ovsdb: Simplify code in do_trigger().

Ben Pfaff blp at ovn.org
Fri Dec 8 19:43:31 UTC 2017


Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 tests/test-ovsdb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c
index 553a4f6a5bf1..ae679c1319e9 100644
--- a/tests/test-ovsdb.c
+++ b/tests/test-ovsdb.c
@@ -1531,10 +1531,10 @@ do_trigger(struct ovs_cmdl_context *ctx)
         }
 
         ovsdb_trigger_run(db, now);
-        while (!ovs_list_is_empty(&session.completions)) {
-            do_trigger_dump(CONTAINER_OF(ovs_list_pop_front(&session.completions),
-                                         struct test_trigger, trigger.node),
-                            now, "delayed");
+
+        struct test_trigger *t;
+        LIST_FOR_EACH_POP (t, trigger.node, &session.completions) {
+            do_trigger_dump(t, now, "delayed");
         }
 
         ovsdb_trigger_wait(db, now);
-- 
2.10.2



More information about the dev mailing list