[ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

[aserdean at ovn.org]

I was concerned a bit about binary compatibility between the future
userspace binaries and older kernel versions.

But Windows users usually just use the MSI (because of the signing issues).

Thanks both!

Alin.

> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> bounces at openvswitch.org] On Behalf Of Sairam Venugopal
> Sent: Friday, December 8, 2017 1:26 AM
> To: aserdean at ovn.org; 'Justin Pettit' <jpettit at ovn.org>;
> dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for
> deleting zone.
> 
> We can hold off on back-porting this. This change mainly affects the
delete
> by 5-tuple API.
> 
> https://github.com/openvswitch/ovs/commit/817a76577fec3f03310d7d3a5a
> 10df01340ee8ad
> 
> Unless we plan to backport that patch, we should hold off on backporting
this
> as well.
> 
> Thanks,
> Sairam
> 
> 
> 
> On 12/6/17, 9:41 AM, "aserdean at ovn.org" <aserdean at ovn.org> wrote:
> 
> >> -----Original Message-----
> >> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> >> bounces at openvswitch.org] On Behalf Of Justin Pettit
> >> Sent: Tuesday, December 5, 2017 9:30 AM
> >> To: dev at openvswitch.org; Alin Gabriel Serdean <aserdean at ovn.org>;
> >> Sairam Venugopal <vsairam at vmware.com>
> >> Subject: [ovs-dev] [PATCH] datapath-windows: Correct endianness for
> >> deleting zone.
> >>
> >> The zone Netlink attribute is supposed to be in network-byte order,
> >> but
> >the
> >> Windows code for deleting conntrack entries was treating it as
> >> host-byte order.
> >>
> >> Found by inspection.
> >>
> >> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> >
> >Thanks for the patch, Justin.  I tested the patch, and everything looks
> >good.
> >I want to hold on the acknowledge until all of us are on the same page.
> >
> >This will make the windows datapath consistent with future patches from
> >the userspace.
> >For consistency I would like to backport the patch all the way to
> >branch-2.6.
> >
> >What do you think Sai?
> >
> >Thanks,
> >Alin.
> >
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev