[ovs-dev] OVS DPDK: dpdk_merge pull request

[Ben Pfaff]

On Mon, Dec 11, 2017 at 06:56:12PM +0000, Stokes, Ian wrote:
> > On Fri, Dec 08, 2017 at 10:14:49PM +0000, Stokes, Ian wrote:
> > > The following changes since commit
> > 65d9759c4fc433dbda89ad3d7225c1f5eac274ca:
> > >
> > >   ovsdb-data: Add OVS_WARN_UNUSED_RESULT annotations to function
> > definitions. (2017-12-08 13:39:29 -0800)
> > >
> > > are available in the git repository at:
> > >
> > >   https://github.com/istokes/ovs dpdk_merge
> > >
> > > for you to fetch changes up to 3eb8d4fa0db3159a8ffc8f52223417b3417263b3:
> > 
> > Thanks a lot.  I merged this to master.
> 
> Thanks for this Ben.
> 
> > 
> > This merge added one new "sparse" warning.  I sent a fix for review:
> >         https://patchwork.ozlabs.org/patch/847165/
> 
> 
> I recompiled with sparse to see if I could reproduce the issue but I don't see that warning.
> 
> I'm concerned that there could be a problem with sparse on my build system at this stage as this is the second time an issue picked up by your build but not on mine.

Do you build with C=1 on the make command line?  That is required to
enable sparse, if it is installed.

This has caused surprises for others in the past.  Maybe we should
change it.

> I obviously need to look into this, out of interest what version of sparse do you use?

It looks like I have v0.5.0-44-g40791b9.  I don't think the particular
version should matter in this case.