[ovs-dev] [PATCH 0/3] Fix tunnel neighbor cache population

Gregory Rose gvrose8192 at gmail.com
Tue Dec 12 16:13:18 UTC 2017


On 12/5/2017 2:43 AM, Zoltan Balogh wrote:
> Currenlty, OVS snoops any ARP or ND packets in any bridge and populates
> the tunnel neighbor cache with the retreived data. For instance, when
> ARP reply originated by a tenant is received on an overlay bridge, the
> ARP message is snooped and tunnel neighbor cache is filled with tenant
> data, however only tunnel neighbor data should be stored there.
> In worst case tunnel peer data could be overwritten in the cache. Which
> triggers revalidation as well.
>
> This series resolves the issue, by trying to snoop ARP and ND messages
> addressing tunnel end point in current bridge.
>
> Zoltan Balogh (3):
>    ofproto-dpif-sflow: propagate actions within clone
>    tests: modify ARP snoop tests for tunneling with clone
>    xlate: call tnl_neigh_snoop() from terminate_native_tunnel()
>
>   include/sparse/netinet/in.h   |  10 +++
>   lib/tnl-neigh-cache.c         |   1 +
>   ofproto/ofproto-dpif-sflow.c  |  19 ++++--
>   ofproto/ofproto-dpif-sflow.h  |   2 +-
>   ofproto/ofproto-dpif-upcall.c |   2 +-
>   ofproto/ofproto-dpif-xlate.c  | 150 ++++++++++++++++++++++++++++++++++++++++--
>   tests/ofproto-dpif.at         |   2 +-
>   tests/tunnel-push-pop-ipv6.at |  78 ++++++++++++++++++++--
>   tests/tunnel-push-pop.at      |  91 +++++++++++++++++++++----
>   9 files changed, 319 insertions(+), 36 deletions(-)
>

Zoltan,

Thanks for your work on this.  I have tested and reviewed your patches 
and everything looks OK to me
except for some checkpatch errors on the first patch in the series. If 
you can fix that up and resubmit
then I'll be happy to provide tested-by and reviewed-by acks.

Thanks!

- Greg


More information about the dev mailing list