[ovs-dev] [PATCH] docs: Fix table view for VM config in dpdk howto.

Stephen Finucane stephen at that.guru
Wed Dec 13 09:27:33 UTC 2017


On Tue, 2017-12-12 at 16:19 +0300, Ilya Maximets wrote:
> In current version table contains only one row with all the values
> together. This is not readable. 'Simple table' format should work for
> this case.
> 
> CC: Stephen Finucane <stephen at that.guru>
> Fixes: 167703d664fc ("doc: Convert INSTALL.DPDK to rST")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>

Some suggestion for other, not-totally-related improvements below, but
this looks good.

Acked-by: Stephen Finucane <stephen at that.guru>

> ---
>  Documentation/howto/dpdk.rst | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/howto/dpdk.rst
> b/Documentation/howto/dpdk.rst
> index d123819..763b237 100644
> --- a/Documentation/howto/dpdk.rst
> +++ b/Documentation/howto/dpdk.rst
> @@ -531,16 +531,18 @@ Add test flows to forward packets betwen DPDK
> devices and VM ports::
>  
>  Create a VM using the following configuration:
>  
> -+----------------------+--------+-----------------+
> -| configuration        | values | comments        |
> -+----------------------+--------+-----------------+
> -| qemu version         | 2.2.0  | n/a             |
> -| qemu thread affinity | core 5 | taskset 0x20    |
> -| memory               | 4GB    | n/a             |
> -| cores                | 2      | n/a             |
> -| Qcow2 image          | CentOS7| n/a             |
> -| mrg_rxbuf            | off    | n/a             |
> -+----------------------+--------+-----------------+
> +.. table::
> +
> +    ===================== ======== ============
> +        configuration      values    comments
> +    ===================== ======== ============
> +    qemu version          2.2.0    n/a
> +    qemu thread affinity  core 5   taskset 0x20
> +    memory                4GB      n/a
> +    cores                 2        n/a

We might want to capitalize these while we're at it.

  QEMU version
  Memory
  ...

> +    Qcow2 image           CentOS7  n/a
> +    mrg_rxbuf             off      n/a
> +    ===================== ======== ============
>  
>  You can do this directly with QEMU via the ``qemu-system-x86_64``
> application::
>  



More information about the dev mailing list