[ovs-dev] [PATCH] netdev-tc-offloads: Use customary types for buffer.
Ben Pfaff
blp at ovn.org
Fri Dec 22 19:21:42 UTC 2017
On Thu, Dec 21, 2017 at 04:39:04PM -0800, Justin Pettit wrote:
>
>
> > On Nov 27, 2017, at 1:53 PM, Ben Pfaff <blp at ovn.org> wrote:
> >
> > This function uses local array set_buff[] to store Netlink attributes.
> > It declares set_buff as an array of character pointers, which is a strange
> > type for a buffer of non-character-pointer objects. In OVS it is
> > customary to use an ofpbuf with a stub of uint64_t objecs (to ensure
> > proper alignment, otherwise uint8_t would be more usual). This commit
> > changes to that more usual form.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
>
> Acked-by: Justin Pettit <jpettit at ovn.org>
Thanks, applied to master.
More information about the dev
mailing list