[ovs-dev] [PATCH] lib: Make error messages more useful
Ben Pfaff
blp at ovn.org
Thu Dec 28 19:25:20 UTC 2017
On Thu, Dec 28, 2017 at 10:22:35AM -0800, Greg Rose wrote:
> There are many "opening datapath" error messages and when one occurs
> it is impossible to know just from the log message which of the
> "opening datapath" errors occurred. Add additional log information
> identifying the datapath argument name and the line number.
>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
I think that it's a bad idea to expose internals, like line numbers, to
users. It looks like every one of these is for a different command. A
better approach would probably be to just include the command name.
It would probably be even better to just add a helper function that
incorporates emitting the error message, so that we don't have as much
duplicate code.
More information about the dev
mailing list