[ovs-dev] [PATCH v2] sflow: Expose ethernet stats via sFlow

[Neil McKee]

Robert,

It's great to get the multicast and broadcast counters in there.

I do wonder if it's worth including the whole ethernet stats block just to
distinguish alignment / FCS /  frame-too-long errors, given that total
errors is already a counter in the generic block.   I know that some follow
symbolErrors particularly carefully.  I think because those are good for
early-warning of fiber/laser degradation.  Any chance we could get those
too?

So it's a thumbs-up from me,  with the hope that we can add symbolErrors
later.

Neil


On Wed, Feb 1, 2017 at 11:35 PM, Robert Wojciechowicz <
robertx.wojciechowicz at intel.com> wrote:

> On Thu, Dec 08, 2016 at 12:23:15PM +0000, Robert Wojciechowicz wrote:
> > Expose existing netdev stats via sFlow.
> > Export sFlow ETHERNET structure with available counters.
> > Map existing stats to counters in the GENERIC INTERFACE
> > sFlow structure.
> > Adjust unit test to accommodate these new counters.
> >
>
> any comments to this patch?
>
> Br,
> Robert
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>