[ovs-dev] [PATCH] ofp-actions: Fix tunnel meatdata subfield length in flow action

Ben Pfaff blp at ovn.org
Thu Feb 2 18:45:50 UTC 2017


On Mon, Jan 09, 2017 at 06:09:33PM -0800, Yi-Hung Wei wrote:
> Previously, if a flow action that involves a tunnel metadata subfield is
> dumpped from vswitchd, the replied subfield length in the OXM header is
> filled with the maximum possible field length, instead of the length
> configured in the tunnel TLV mapping table.
> 
> In order to derive the correct length of a tun_metadata subfield, this patch
> passes the tunnel TLV mapping table (struct tun_table) to where we decode
> the flow actions. extract-ofp-actions is updated to pass the tunnel TLV mapping
> table to the flow action decoding functions. Also, a new error code is
> introduced to identify a flow with an invalid tun_metadata ID. Moreover, a
> testcase is added to prevent future regressions.
> 
> Currently, this patch only addresses the usage of tun_metaata for REG_MOVE action.
> Other actions that may use the tun_metadata will be addressed in subsequent patches.
> 
> VMWare-BZ: #1768370
> Reported-by: Harold Lim <haroldl at vmware.com>
> Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>

I think I've seen some side discussion on this patch.  Is it still
relevant as is or is some revision already in progress?

In any case, s/meatdata/metadata/ in the subject.


More information about the dev mailing list