[ovs-dev] [PATCH 3/3] rhel: Fix ifup and ifdown after DPDK naming change.

Ben Pfaff blp at ovn.org
Thu Feb 2 20:48:35 UTC 2017


On Tue, Jan 24, 2017 at 06:21:53PM -0800, Daniele Di Proietto wrote:
> Names like dpdk0 and dpdk1 are not enough to identify a DPDK interface.
> We could update README.RHEL.rst and add
> 
> OVS_EXTRA='set Interface ${DEVICE} options:dpdk-devargs=0000:01:00.0'
> 
> but a better solution is to add new parameters in the configuration file
> to explicitly specify the dpdk-devargs.
> 
> Fixes: 55e075e65ef9("netdev-dpdk: Arbitrary 'dpdk' port naming")
> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>

This seems useful.

I don't understand why this uses "set" then $1.  Are you concerned that
BOND_DPDK_DEVARGS might have multiple words and you want to get just the
first one?

>  	OVSDPDKBond)
>  		ifup_ovs_bridge
> +		set -- ${BOND_DPDK_DEVARGS}
>  		for _iface in $BOND_IFACES; do
> -			IFACE_TYPES="${IFACE_TYPES} -- set interface ${_iface} type=dpdk"
> +			IFACE_TYPES="${IFACE_TYPES} -- set interface ${_iface} type=dpdk options:dpdk-devargs=$1"
> +			shift
>  		done
>  		ovs-vsctl -t ${TIMEOUT} \
>  			-- --if-exists del-port "$OVS_BRIDGE" "$DEVICE" \


More information about the dev mailing list