[ovs-dev] [patch_v4 5/6] Enable NAT tests for userspace datapath.
Darrell Ball
dball at vmware.com
Wed Feb 8 03:04:52 UTC 2017
On 2/7/17, 6:46 PM, "ovs-dev-bounces at openvswitch.org on behalf of Darrell Ball" <ovs-dev-bounces at openvswitch.org on behalf of dball at vmware.com> wrote:
On 1/27/17, 5:57 PM, "ovs-dev-bounces at openvswitch.org on behalf of Daniele Di Proietto" <ovs-dev-bounces at openvswitch.org on behalf of diproiettod at ovn.org> wrote:
2017-01-24 20:40 GMT-08:00 Darrell Ball <dlu998 at gmail.com>:
> Signed-off-by: Darrell Ball <dlu998 at gmail.com>
Thanks for the patch.
The macro is now empty for kernel and userspace.
Would you mind removing it from system-userspace-macros,
system-kmod-macros and from the testsuites?
As discussed, the macro is probably useful to retain for future datapaths
and kernel compatibility.
Also some of the NAT tests fail for me, I guess because they use ALGs:
57: conntrack - FTP NAT prerecirc FAILED
(system-traffic.at:2693)
58: conntrack - FTP NAT prerecirc seqadj FAILED
(system-traffic.at:2704)
59: conntrack - FTP NAT postrecirc FAILED
(system-traffic.at:2756)
60: conntrack - FTP NAT postrecirc seqadj FAILED
(system-traffic.at:2767)
62: conntrack - IPv6 FTP with NAT FAILED
(system-traffic.at:2859)
I think adding CHECK_CONNTRACK_ALG() to them should skip them for the
userspace datapath.
For the VM I was using the FTP tests are skipped, as expected.
However, this was due to the lack of supported FTP server which
is another guard check.
So I did not notice the missing CHECK_CONNTRACK_ALG() guards.
The CHECK_CONNTRACK_ALG() guard was present correctly for some tests.
[conntrack - FTP]
[conntrack - FTP over IPv6]
[conntrack - FTP with multiple expectations]
[conntrack - TFTP]
but was missing for the macro
m4_define([CHECK_FTP_NAT] used for 4 tests
and the
[conntrack - IPv6 FTP with NAT] test
I’ll added the missing guards.
> ---
> tests/system-userspace-macros.at | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at
> index 631f71a..6e3d468 100644
> --- a/tests/system-userspace-macros.at
> +++ b/tests/system-userspace-macros.at
> @@ -99,9 +99,6 @@ m4_define([CHECK_CONNTRACK_LOCAL_STACK],
> # CHECK_CONNTRACK_NAT()
> #
> # Perform requirements checks for running conntrack NAT tests. The userspace
> -# doesn't support NATs yet, so skip the tests
> +# datapath supports NAT.
> #
> -m4_define([CHECK_CONNTRACK_NAT],
> -[
> - AT_SKIP_IF([:])
> -])
> +m4_define([CHECK_CONNTRACK_NAT])
> --
> 1.9.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=9DNNbwp0o3NtTNugzo5IpG6GZkc99lH4bjen-B23KMU&s=qsT9M7D5IfzovSJ1xlwH5wTRKsB2a_skIGaezx19oAY&e=
_______________________________________________
dev mailing list
dev at openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=9DNNbwp0o3NtTNugzo5IpG6GZkc99lH4bjen-B23KMU&s=qsT9M7D5IfzovSJ1xlwH5wTRKsB2a_skIGaezx19oAY&e=
_______________________________________________
dev mailing list
dev at openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=-A6_QwGRLzJZ00Dw6dCvYHgwNh9-8FKzjs1D8FUhsgo&s=tBAo2E31q_4qOJ4NJI7wDFmNql-HnvPpbHfbyFfv844&e=
More information about the dev
mailing list