[ovs-dev] [PATCH] ofctrl: Free contents of symbol table in ofctrl_destroy().

Ben Pfaff blp at ovn.org
Wed Feb 8 19:18:05 UTC 2017


Thanks, applied to master and branch-2.7.

On Wed, Feb 08, 2017 at 10:46:29AM -0800, William Tu wrote:
> thanks! I tested it and found no problem.
> 
> On Wed, Feb 8, 2017 at 8:40 AM, Ben Pfaff <blp at ovn.org> wrote:
> > This fixes a memory leak, although it was not a significant leak because
> > the symbol table is in use until shortly before ovn-controller exits.
> >
> > Reported-by: William Tu <u9012063 at gmail.com>
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> >  ovn/controller/ofctrl.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c
> > index 3876ff6..10c8105 100644
> > --- a/ovn/controller/ofctrl.c
> > +++ b/ovn/controller/ofctrl.c
> > @@ -549,6 +549,7 @@ ofctrl_destroy(void)
> >      rconn_destroy(swconn);
> >      ovn_flow_table_destroy(&installed_flows);
> >      rconn_packet_counter_destroy(tx_counter);
> > +    expr_symtab_destroy(&symtab);
> >      shash_destroy(&symtab);
> >  }
> >
> > --
> > 2.10.2
> >


More information about the dev mailing list