[ovs-dev] [PATCH 3/3] ovsdb: Prevent OVSDB server from replicating itself.

Ben Pfaff blp at ovn.org
Wed Feb 8 19:40:00 UTC 2017


On Tue, Feb 07, 2017 at 08:40:22PM -0800, Andy Zhou wrote:
> Replication OVSDB server from itself is usually caused by configuration
> errors. Such configuration errors can lead to OVSDB server data loss.
> See "reported-at" for more details.
> 
> This patch adds logics that prevent OVSDB server from replicating
> itself.
> 
> Reported-by: Guishuai Li <ligs at dtdream.com>
> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-January/326963.html
> Suggested-by: Ben Pfaff <blp at ovn.org>
> Signed-off-by: Andy Zhou <azhou at ovn.org>

In the manpage, "vSwitch" is not capitalized correctly, and I'd add a
little more detail, something like this:

diff --git a/ovsdb/ovsdb-server.1.in b/ovsdb/ovsdb-server.1.in
index b0f488e..49ff5a6 100644
--- a/ovsdb/ovsdb-server.1.in
+++ b/ovsdb/ovsdb-server.1.in
@@ -578,7 +578,7 @@ but in the response object to the monitor_cond request. The formatting
 of the <table-updates2> object, however, is the same in either case.
 .
 .IP "4.1.15. Get Server ID"
-A new RPC method added in Open vSWitch version 2.7. The request contains
+A new RPC method added in Open vSwitch version 2.7. The request contains
 the following members:
 .
 .PP
@@ -604,7 +604,8 @@ The response object contains the following members:
 .
 .IP
 <server_id> is JSON string that contains a UUID that uniquely identifies
-the OVSDB server instance.
+the running OVSDB server process.  A fresh UUID is generated when the
+process restarts.
 .
 .IP "5.1. Notation"
 For <condition>, RFC 7047 only allows the use of \fB!=\fR, \fB==\fR,

In replication_init(), I'd use "=" to copy the uuid, instead of
memcpy().

It would be nice to get feedback from the original reporter.  Presumably
it solves his problem but perhaps he'll have additional insight.

Acked-by: Ben Pfaff <blp at ovn.org>


More information about the dev mailing list