[ovs-dev] [PATCH] windows: netdev report error if query failed

Alin Serdean aserdean at cloudbasesolutions.com
Thu Feb 9 16:23:21 UTC 2017


Thanks Guru.

Can you please apply https://github.com/openvswitch/ovs/commit/583d34678d32482d616fe5bd7dc323f044788898 on branch-2.6 ?

Thanks,
Alin.

From: Guru Shetty [mailto:guru at ovn.org]
Sent: Wednesday, February 8, 2017 8:19 PM
To: Alin Serdean <aserdean at cloudbasesolutions.com>
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] windows: netdev report error if query failed



On 7 February 2017 at 22:41, Alin Serdean <aserdean at cloudbasesolutions.com<mailto:aserdean at cloudbasesolutions.com>> wrote:
The netdev Windows construct uses query_netdev to see if a port exists
in the datapath, in the case an error occurred in the reply message
we returned 0, meaning netdev_open was successful.

This patch fixes fixes that problem.

Reported-at: https://github.com/openvswitch/ovs-issues/issues/125
Reported-by: Shashank Ram <rams at vmware.com<mailto:rams at vmware.com>>
Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com<mailto:aserdean at cloudbasesolutions.com>>
---
intended for: branch-2.5, branch-2.6, branch-2.7, master
Thanks, applied to all the above branches.

---
 lib/netdev-windows.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c
index c2fbe42..b22bd09 100644
--- a/lib/netdev-windows.c
+++ b/lib/netdev-windows.c
@@ -295,7 +295,7 @@ query_netdev(const char *devname,
         }
     }

-    return 0;
+    return error;
 }

 static void
--
2.10.2.windows.1
_______________________________________________
dev mailing list
dev at openvswitch.org<mailto:dev at openvswitch.org>
https://mail.openvswitch.org/mailman/listinfo/ovs-dev



More information about the dev mailing list