[ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

[Valentine Sinitsyn]

Hi Jan,

On 10.02.2017 04:14, Jan Scheurich wrote:
> Hi Valentine,
>
> On 2017-02-09 08:58, Valentine Sinitsyn wrote:
>> This L3 patchset looks similar to what we did internally with OVS 2.6
>> to add support for IPv6 tunnels.
>>
>> Could you please confirm that ovs-dpctl reports correct statistics
>> with this patchset when one uses in-kernel Linux datapath? We had some
>> issues with this (the counters were always zero). Largely, this was
>> because userspace code (I refer to the tools and the daemon, not DPDK
>> datapath here) assumes a plugged network interface is always L2, and I
>> don't see this patch touching these files.
>>
> The most recent user-space code in vswitchd that deals with the L3
> tunnels in netdev and kernel datapath is contained in another patch
> series:
> https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328391.html
>
> You could help in reviewing that. It may not be complete with respect to
> handling kernel datapath tunnels as we were not able to test yet due to
> a lack of patches to configure L3 tunnel ports in the kernel. But
> similar problems with counters might also exist with netdev datapath.
I had a quick look at patch series, thanks for the links. Will try to 
have a more in-depth look this week.

As for the "counters issue" I mentioned, it seems tiny given the scope 
of the patchset. Moreover, a get_etheraddr() change in [1] should fix 
it, although I haven't checked yet.

[1] https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328392.html

Best,
Valentine

>
> Thanks, Jan
>