[ovs-dev] [PATCH ovs V3 04/25] other-config: Add hw-offload switch to control netdev flow offloading

Roi Dayan roid at mellanox.com
Wed Feb 15 07:30:14 UTC 2017



On 14/02/2017 01:53, Chandran, Sugesh wrote:
>
>
> Regards
> _Sugesh
>
>
>> -----Original Message-----
>> From: Roi Dayan [mailto:roid at mellanox.com]
>> Sent: Wednesday, February 8, 2017 3:29 PM
>> To: dev at openvswitch.org
>> Cc: Paul Blakey <paulb at mellanox.com>; Or Gerlitz
>> <ogerlitz at mellanox.com>; Hadar Hen Zion <hadarh at mellanox.com>; Shahar
>> Klein <shahark at mellanox.com>; Mark Bloch <markb at mellanox.com>; Rony
>> Efraim <ronye at mellanox.com>; Fastabend, John R
>> <john.r.fastabend at intel.com>; Joe Stringer <joe at ovn.org>; Andy
>> Gospodarek <andy at greyhouse.net>; Lance Richardson
>> <lrichard at redhat.com>; Marcelo Ricardo Leitner <mleitner at redhat.com>;
>> Simon Horman <simon.horman at netronome.com>; Jiri Pirko
>> <jiri at mellanox.com>; Chandran, Sugesh <sugesh.chandran at intel.com>
>> Subject: [PATCH ovs V3 04/25] other-config: Add hw-offload switch to control
>> netdev flow offloading
>>
>> From: Paul Blakey <paulb at mellanox.com>
>>
>>      }
>>
>> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index
>> 146a816..942e68f 100644
>> --- a/vswitchd/vswitch.xml
>> +++ b/vswitchd/vswitch.xml
>> @@ -170,6 +170,17 @@
>>          <p>
>>            The default is 10000.
>>          </p>
>> +    </column>
>> +
>> +      <column name="other_config" key="hw-offload"
>> +              type='{"type": "boolean"}'>
>> +        <p>
>> +          Set this value to <code>true</code> to enable netdev flow offload.
>> +        </p>
>> +        <p>
>> +          The default value is <code>false</code>. Changing this value requires
>> +          restarting the daemon
> [Sugesh] Hope its only the case of current implementation. Its possible to change the hardware offload status at run-time in the future. The system will re-populate the hardware ports accordingly when the status get changed.

We actually already changed that and the current implementation is same 
as for dpdk-init where we can change from false to true during run time 
but not from true back to false again. can be fixed later.

In case you do change this at run time we are missing to go over the 
netdevs and add the needed ingress qdisc so this will be needed to be 
done manually if working with this patchset.
We intend to fix this for V4.

I see the comment requiring restart also still exists for dpdk-init.
Maybe we should keep it currently as well until it's fully supported..

>> +        </p>
>>        </column>
>>
>>        <column name="other_config" key="dpdk-init"
>> --
>> 2.7.4
>


More information about the dev mailing list