[ovs-dev] [PATCH 1/4] ofproto/bond: Validate active-slave mac.

[Andy Zhou]

On Tue, Feb 14, 2017 at 7:48 PM, Andy Zhou <azhou at ovn.org> wrote:
> On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao
> <nic at opencloud.tech> wrote:
>> That the mac of active-slave is invalid(e.g. 00:00:00:00:00:00)
>> is incidental. The reason is described as below.
>>
>> In the bridge_reconfig():
>> 1. bond devices created in port_configure().
>> 2. the bonded interfaces may be disabled even calling bridge_run__(),
>>    because the interface link is not ready.
>>
>> The OvS will run bridge_run__() in next loop. In next loop, the
>> active-slave may be selected. But OvS the bridge_reconfig() again,
>> the bond_reconfigure() set active-slave mac zero and flag false.
>> If using the 'ovs-appctl bond/show bond-name' to check active-slave
>> mac, you will find the mac is zero and mac in the ovsdb is also zero.
>>
>> The active_slave_mac and active_slave_changed should be initialized
>> when created.
>>
>> Signed-off-by: nickcooper-zhangtonghao <nic at opencloud.tech>
>
> Thanks for working on this!
>
> This patch looks good to me. I will push it after we converged on the other
> patches in the series.
>
>
> Acked-by: Andy Zhou <azhou at ovn.org>

Pushed to master. Also to branch-2.5 2.6 and 2.7