[ovs-dev] [PATCH 5/8] datapath: remove unused functions

Jarno Rajahalme jarno at ovn.org
Thu Feb 16 01:34:17 UTC 2017


From: Jiri Benc <jbenc at redhat.com>

Upstream commit:

    commit f33eb0cf9984f79e8643eaac888e4b6a06a8e221
    Author: Jiri Benc <jbenc at redhat.com>
    Date:   Wed Oct 19 11:26:36 2016 +0200

    openvswitch: remove unused functions

    ovs_vport_deferred_free is not used anywhere. It's the only caller of
    free_vport_rcu thus this one can be removed, too.

    Signed-off-by: Jiri Benc <jbenc at redhat.com>
    Acked-by: Pravin B Shelar <pshelar at ovn.org>
    Signed-off-by: David S. Miller <davem at davemloft.net>
    Signed-off-by: Jarno Rajahalme <jarno at ovn.org>

Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
---
 datapath/vport.c | 16 ----------------
 datapath/vport.h |  1 -
 2 files changed, 17 deletions(-)

diff --git a/datapath/vport.c b/datapath/vport.c
index c29f0b0..7ac4632 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -509,22 +509,6 @@ int ovs_vport_receive(struct vport *vport, struct sk_buff *skb,
 }
 EXPORT_SYMBOL_GPL(ovs_vport_receive);
 
-static void free_vport_rcu(struct rcu_head *rcu)
-{
-	struct vport *vport = container_of(rcu, struct vport, rcu);
-
-	ovs_vport_free(vport);
-}
-
-void ovs_vport_deferred_free(struct vport *vport)
-{
-	if (!vport)
-		return;
-
-	call_rcu(&vport->rcu, free_vport_rcu);
-}
-EXPORT_SYMBOL_GPL(ovs_vport_deferred_free);
-
 static unsigned int packet_length(const struct sk_buff *skb)
 {
 	unsigned int length = skb->len - ETH_HLEN;
diff --git a/datapath/vport.h b/datapath/vport.h
index 47995be..d14908f 100644
--- a/datapath/vport.h
+++ b/datapath/vport.h
@@ -152,7 +152,6 @@ struct vport_ops {
 struct vport *ovs_vport_alloc(int priv_size, const struct vport_ops *,
 			      const struct vport_parms *);
 void ovs_vport_free(struct vport *);
-void ovs_vport_deferred_free(struct vport *vport);
 
 #define VPORT_ALIGN 8
 
-- 
2.1.4



More information about the dev mailing list