[ovs-dev] [PATCH] Makefile.am: Suppress echoing of "Avoid include/ depending on lib/" commands

Timothy Redaelli tredaelli at redhat.com
Wed Feb 22 23:14:37 UTC 2017


On Wed, Feb 22, 2017 at 10:03 PM, Joe Stringer <joe at ovn.org> wrote:
> On 22 February 2017 at 08:18, Timothy Redaelli <tredaelli at redhat.com> wrote:
<cut>

> I suggest the following instead, does this work for you?
>
> diff --git a/Makefile.am b/Makefile.am
> index 7ff66fe15086..a4dd7b8dd16a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -229,8 +229,8 @@ config-h-check:
>          echo "See above for list of violations of the rule that"; \
>          echo "every C source file must #include <config.h>."; \
>          exit 1; \
> -       fi
> -       if grep '#include' $(srcdir)/include/openvswitch/*.h | \
> +       fi; \
> +       if grep '#include' include/openvswitch/*.h | \
>            grep -vE '(<.*>)|("openvswitch)|("openflow)'; \
>        then \
>          echo "See above for list of violations of the rule that"; \

Looks good to me.

Thank you


More information about the dev mailing list