[ovs-dev] [PATCH] datapath-windows: geneve option header is in BE

Yin Lin yinlin10 at gmail.com
Tue Feb 28 19:37:04 UTC 2017


Good catch. Thanks Alin for the fixing this! Wondering why I didn't caught
it earlier.

Acked-by: Yin Lin <linyi at vmware.com>

On Fri, Feb 17, 2017 at 4:44 AM, Alin Serdean <
aserdean at cloudbasesolutions.com> wrote:

> At the moment on Windows we suport only LE platforms.
>
> The option header is currently defined in BE.
>
> Found while testing.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> ---
>  datapath-windows/ovsext/Geneve.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/datapath-windows/ovsext/Geneve.h b/datapath-windows/ovsext/
> Geneve.h
> index be8a834..019c0dd 100644
> --- a/datapath-windows/ovsext/Geneve.h
> +++ b/datapath-windows/ovsext/Geneve.h
> @@ -71,10 +71,10 @@ typedef struct GeneveOptionHdr {
>      UINT32   optionClass:16;
>      /* Format of data contained in the option. */
>      UINT32   type:8;
> -    /* Reserved. */
> -    UINT32   reserved:3;
>      /* Length of option in int32 excluding the option header. */
>      UINT32   length:5;
> +    /* Reserved. */
> +    UINT32   reserved:3;
>  } GeneveOptionHdr;
>
>  #define GENEVE_CRIT_OPT_TYPE (1 << 7)
> --
> 2.10.2.windows.1
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list