[ovs-dev] [PATCH v2 5/5] make: Standardize indentation

Ben Pfaff blp at ovn.org
Wed Jan 4 16:57:38 UTC 2017

On Mon, Jan 02, 2017 at 11:47:42AM +0000, Stephen Finucane wrote:
> If we're going to mix tabs and spaces, let's do it consistently.
> Signed-off-by: Stephen Finucane <stephen at that.guru>

The formatting of the commands for flake8-check seemed particularly
awful, so I changed them to:

    FLAKE8_SELECT = H231,H232,H233,H238
    FLAKE8_IGNORE = E121,E123,E125,E126,E127,E128,E129,E131,W503,F811,D,H
    flake8-check: $(FLAKE8_PYFILES)
            $(AM_V_GEN) \
              src='$^' && \
              flake8 $$src --select=$(FLAKE8_SELECT) $(FLAKE8_FLAGS) && \
              flake8 $$src --ignore=$(FLAKE8_IGNORE) $(FLAKE8_FLAGS) && \
              touch $@

which is much more readable.

It's something of a sin to do whitespace and non-whitespace changes at
the same time.  Oops.

I applied this series, minus patch 4, to master.  Thanks again!

More information about the dev mailing list