[ovs-dev] [PATCH v4 1/3] netdev-dpdk: add hotplug support

Daniele Di Proietto diproiettod at ovn.org
Thu Jan 5 00:17:52 UTC 2017


2017-01-04 8:20 GMT-08:00 Stephen Finucane <stephen at that.guru>:
> On Wed, 2017-01-04 at 15:31 +0000, Ciara Loftus wrote:
>> In order to use dpdk ports in ovs they have to be bound to a DPDK
>> compatible driver before ovs is started.
>>
>> This patch adds the possibility to hotplug (or hot-unplug) a device
>> after ovs has been started. The implementation adds two appctl
>> commands:
>> netdev-dpdk/attach and netdev-dpdk/detach
>>
>> After the user attaches a new device, it has to be added to a bridge
>> using the add-port command, similarly, before detaching a device,
>> it has to be removed using the del-port command.
>
> There are a couple of issues with the documentation part of this that
> would be good to fix if/when you respin. I'll leave the rest of the
> changes to someone better qualified to review them.
>
> Stephen

Thanks for the patch Ciara it looks good to me.

Since you put these tags:

Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal at studenti.polito.it>
Signed-off-by: Ciara Loftus <ciara.loftus at intel.com>
Co-authored-by: Ciara Loftus <ciara.loftus at intel.com>

should the author be Mauricio?

If you want to respin including Stephen's comments (thanks!) I'll be
happy to apply it.  Otherwise I can make the changes myself before
pushing it.

Thanks,

Daniele


More information about the dev mailing list