[ovs-dev] [PATCH] Windows tests: Applications abort when using threading (ovs_rwlock_init)

[Alin Serdean]

> -----Original Message-----
> From: Ben Pfaff [mailto:blp at ovn.org]
> Sent: Wednesday, January 4, 2017 7:21 PM
> To: Alin Serdean <aserdean at cloudbasesolutions.com>
> Cc: dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] Windows tests: Applications abort when
> using threading (ovs_rwlock_init)
> 
> On Wed, Dec 28, 2016 at 10:27:17PM +0000, Alin Serdean wrote:
> > Commit number: 1a15f390afd66efd161db78b86600832214dfb3c
> >
> https://github.com/openvswitch/ovs/commit/1a15f390afd66efd161db78b86
> 60
> > 0832214dfb3c switched from `NULL` to `attr`. According to POSIX
> > documentation this is correct, unfortunately on Windows the current
> > implementation of pthreads does not support a pre-initialized
> > attribute. Please see a fork of the implementation
> > https://github.com/GerHobbelt/pthread-
> win32/blob/19fd5054b29af1b4e3b32
> > 78bfffbb6274c6c89f5/pthread_rwlock_init.c#L59-L63
> > This is the same implementation as the official version found under:
> > ftp://sourceware.org/pub/pthreads-win32/)
> 
> Thanks.
> 
> I didn't like that this was Windows-specific, since it was possible to make it
> generic.
> 
> I changed the patch to the following, and applied it to master.
> 
[Alin Serdean] Much nicer. Thanks!