[ovs-dev] *** SPAM *** [PATCH 1/2] ofctrl: Fix version check in ofctrl_inject_packet().

Justin Pettit jpettit at ovn.org
Fri Jan 6 03:13:53 UTC 2017


> On Jan 5, 2017, at 5:03 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> "enum ofp_version" is unsigned in the System V ABI used by Linux, so
> it will never be less than 0, so an rconn with an unnegotiated version will
> never be found properly.  This fixes the problem.
> 
> CC: Justin Pettit <jpettit at ovn.org>
> Fixes: 714651c7db6a ("ovn-controller: Introduce "inject-pkt" ovs-appctl command.")
> Signed-off-by: Ben Pfaff <blp at ovn.org>

Thanks for catching that.

Acked-by: Justin Pettit <jpettit at ovn.org>

--Justin






More information about the dev mailing list