[ovs-dev] [PATCH v2 1/5] datapath-windows: OvsUpdateIPv4Header remove unnecessary addition

Alin Serdean aserdean at cloudbasesolutions.com
Fri Jan 6 19:33:43 UTC 2017


bufferStart can be used directly to access the data of the net buffer.
Add the MDL offset to save unnecessary additions.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
---
v2: no change
---
 datapath-windows/ovsext/Actions.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c
index 2a24410..bf4f25c 100644
--- a/datapath-windows/ovsext/Actions.c
+++ b/datapath-windows/ovsext/Actions.c
@@ -1390,13 +1390,13 @@ OvsUpdateIPv4Header(OvsForwardingContext *ovsFwdCtx,
         mdlLen -= curMdlOffset;
         ASSERT(mdlLen >= hdrSize);
     }
-
-    ipHdr = (IPHdr *)(bufferStart + curMdlOffset + layers->l3Offset);
+    bufferStart += curMdlOffset;
+    ipHdr = (IPHdr *)(bufferStart + layers->l3Offset);
 
     if (layers->isTcp) {
-        tcpHdr = (TCPHdr *)(bufferStart + curMdlOffset + layers->l4Offset);
+        tcpHdr = (TCPHdr *)(bufferStart + layers->l4Offset);
     } else if (layers->isUdp) {
-        udpHdr = (UDPHdr *)(bufferStart + curMdlOffset + layers->l4Offset);
+        udpHdr = (UDPHdr *)(bufferStart + layers->l4Offset);
     }
 
     /*
-- 
2.10.2.windows.1


More information about the dev mailing list