[ovs-dev] [PATCH v3] nx-match: Only store significant bytes to stack.

Jarno Rajahalme jarno at ovn.org
Sat Jan 7 02:36:29 UTC 2017


> On Jan 6, 2017, at 9:03 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Thu, Jan 05, 2017 at 05:44:40PM -0800, Jarno Rajahalme wrote:
>> Always storing the maximum mf_value size wastes about 120 bytes for
>> each stack entry.  This patch changes the stack from an mf_value array
>> to a string of value-length pairs.
>> 
>> The length is stored after the value so that the stack pop may first
>> read the length and then the appropriate number of bytes.
>> 
>> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
>> ---
>> v3: Address Ben's comments and fold in a fix avoiding assert in OVS due to
>>    a controller error.
> 
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks for the review!

Pushed to master and the assert bug fix also to branch-2.6.

  Jarno



More information about the dev mailing list