[ovs-dev] [PATCH 2/4] datapath: Limits the number of tx/rx queues for netdev-dummy.

nickcooper-zhangtonghao nic at opencloud.tech
Mon Jan 9 04:02:23 UTC 2017


Thanks Daniele,
Yes, it’s a small improvement. but it is necessary for us. I will check it in 
set_config(). One question to ask: should we check the tx/rx queue for netdev-dpdk in set_config()?

Now we check it in dpdk_eth_dev_init().

Thanks.



> On Jan 9, 2017, at 11:22 AM, Daniele Di Proietto <diproiettod at ovn.org> wrote:
> 
> 2017-01-08 17:30 GMT-08:00 nickcooper-zhangtonghao <nic at opencloud.tech <mailto:nic at opencloud.tech>>:
>> This patch avoids the ovs_rcu to report WARN, caused by blocked
>> for a long time, when ovs-vswitchd processes a port with many
>> rx/tx queues. The number of tx/rx queues per port may be appropriate,
>> because the dpdk uses it as an default max value.
>> 
>> Signed-off-by: nickcooper-zhangtonghao <nic at opencloud.tech <mailto:nic at opencloud.tech>>
> 
> I don't think this is a big deal, since netdev-dummy is only used for
> testing, but don't you think it's better to check it in set_config()
> and return an error?
> 
> Also, could you use the prefix netdev-dummy, instead of datapath?
> 
> Thanks,
> 
> Daniele



More information about the dev mailing list