[ovs-dev] [v2 1/2] ovsdb-idl: Properly handle conditional monitor update error

[Andy Zhou]

On Fri, Jan 6, 2017 at 4:17 PM, Ben Pfaff <blp at ovn.org> wrote:

> On Fri, Jan 06, 2017 at 02:38:45PM -0800, Andy Zhou wrote:
> > From: andy zhou <azhou at ovn.org>
> >
> > When generating conditional monitoring update request, current code
> > failed to update idl's 'request-id'.  This bug causes the reply
> > message of the update request, regardless an ACK or a NACK, be
> > logged as an unexpected message at the debug level and ignored by
> > the core idl logic.
> >
> > In addition, the idl should not generate another conditional
> > monitoring update request when there is an outstanding request.
> > So that the requests and their reply are properly serialized.
> >
> > When the conditional monitoring is nacked by the server, drop idl
> > into a client visible error state.
> >
> > Signed-off-by: Andy Zhou <azhou at ovn.org>
>
> Acked-by: Ben Pfaff <blp at ovn.org>
>
Thanks. Pushed.