[ovs-dev] [PATCH ovs V2 19/21] dpctl: read vswitch config on start

[Joe Stringer]

On 10 January 2017 at 08:38, Paul Blakey <paulb at mellanox.com> wrote:
>
>
> On 05/01/2017 23:46, Joe Stringer wrote:
>>
>> On 25 December 2016 at 03:39, Paul Blakey <paulb at mellanox.com> wrote:
>>>
>>> Use Open vSwitch IDL pattern to read OVS configuration on dpctl start,
>>> needed as some functionality is dependent on that configuration.
>>>
>>> Signed-off-by: Paul Blakey <paulb at mellanox.com>
>>> Reviewed-by: Roi Dayan <roid at mellanox.com>
>>
>> Why? What functionality?
>
> Since the hw-offload/skip-hw configurations aren't saved with kernel dpif
> and dumped back on open,
> we needed "hw-offload" configuration to know if to try offloading for
> add-flow dpctl command, and then
> which flag to pass on to TC (skip_hw/skip_sw) if offloading is enabled.
> Also for dpctl dump-flows, if hw offload is enabled dump offloaded flows
> from netdevs.

I think we can come up with reasonable defaults that don't require the
database, and commandline flags for anything else. ovs-dpctl is
intended as a standalone debug tool, not a regular configuration
interface.