[ovs-dev] [PATCH] netdev-dpdk: Assign socket id according to device's numa id

[Kevin Traynor]

On 01/11/2017 03:05 PM, Loftus, Ciara wrote:
>>
>> Binbin Xu <xu.binbin1 at zte.com.cn> writes:
>>
>>> After the commit "55e075e65ef9ecbd70e5e0fada2704c3d73724d8
>>> netdev-dpdk: Arbitrary 'dpdk' port naming", we could hotplug
>>> attach DPDK ports specified via the 'dpdk-devargs' option.
>>>
>>> But the socket id of DPDK ports can't be assigned correctly,
>>> it is always 0. The socket id of DPDK ports should be assigned
>>> according to the numa id of the device.
>>>
>>> Signed-off-by: Binbin Xu <xu.binbin1 at zte.com.cn>
>>> ---
>>
>> I haven't reviewed the patch yet, but can you reformat this message with
>> a fixes: tag?  That makes backporting swathes of commits easier.
>>
>> It would be:
>> Fixes: 55e075e65ef9 ("netdev-dpdk: Arbitrary 'dpdk' port naming")
>>
>> I've also CC'd some folks involved in testing / using this patch
> 
> Agree with Aaron re restructuring the commit message. The patch itself looks good to me. Thanks for providing the fix.
> 
> Acked-by: Ciara Loftus <ciara.loftus at intel.com>
> 

LGTM too.

Acked-by: Kevin Traynor <ktraynor at redhat.com>

>>
>> Thanks,
>> Aaron