[ovs-dev] [PATCH v1 0/5] datapath-windows: Add support for Ipv4 fragments

Anand Kumar kumaranand at vmware.com
Thu Jan 12 18:34:47 UTC 2017


Hi Alin,

Thank you for your comments, I will take a look at it.

Regards,
Anand Kumar

On 1/12/17, 8:33 AM, "Alin Serdean" <aserdean at cloudbasesolutions.com> wrote:

    Hi,
    
    Thanks a lot for the series, it will be a great addition to the Windows datapath!
    
    One small nit it does not compile under release because of `ovspool` is defined only in debug mode.
    
    I also tried to set up an environment and for some reason the fragments were stalling. I tried icmp and tcp with no luck.
    
    I will take a better look over the code and come back with more comments.
    
    Thanks,
    Alin.
    
    > -----Original Message-----
    > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
    > bounces at openvswitch.org] On Behalf Of Anand Kumar
    > Sent: Tuesday, January 10, 2017 2:59 AM
    > To: dev at openvswitch.org
    > Subject: [ovs-dev] [PATCH v1 0/5] datapath-windows: Add support for Ipv4
    > fragments
    > 
    > Add support for maintaining and tracking IPv4 fragments.
    > This patch adds a new file IpFragment.c and IpFragment.h which includes
    > Ipv4 fragment related API's.
    > 
    > Anand Kumar (5):
    >   datapath-windows: Added a new file to support Ipv4 fragments.
    >   datapath-windows: Added Ipv4 fragments support in Conntrack
    >   datapath-windows: Retain MRU value in the OvsForwardingContext.
    >   datapath-windows: Updated OvsTcpSegmentNBL to handle IP fragments.
    >   datapath-windows: Fragment NBL based on MRU size
    > 
    >  datapath-windows/automake.mk           |   2 +
    >  datapath-windows/ovsext/Actions.c      |  89 ++++--
    >  datapath-windows/ovsext/Actions.h      |   3 +
    >  datapath-windows/ovsext/BufferMgmt.c   | 189 ++++++++----
    >  datapath-windows/ovsext/BufferMgmt.h   |  10 +-
    >  datapath-windows/ovsext/Conntrack.c    |  31 +-
    >  datapath-windows/ovsext/Conntrack.h    |   7 +-
    >  datapath-windows/ovsext/Debug.h        |   3 +-
    >  datapath-windows/ovsext/DpInternal.h   |   2 +-
    >  datapath-windows/ovsext/Geneve.c       |   2 +-
    >  datapath-windows/ovsext/Gre.c          |   2 +-
    >  datapath-windows/ovsext/IpFragment.c   | 506
    > +++++++++++++++++++++++++++++++++
    >  datapath-windows/ovsext/IpFragment.h   |  74 +++++
    >  datapath-windows/ovsext/PacketIO.c     |   5 +-
    >  datapath-windows/ovsext/Recirc.c       |   6 +-
    >  datapath-windows/ovsext/Recirc.h       |   6 +-
    >  datapath-windows/ovsext/Stt.c          |   2 +-
    >  datapath-windows/ovsext/Switch.c       |   9 +
    >  datapath-windows/ovsext/Tunnel.c       |   4 +-
    >  datapath-windows/ovsext/User.c         |  28 +-
    >  datapath-windows/ovsext/User.h         |   6 +-
    >  datapath-windows/ovsext/Vxlan.c        |   2 +-
    >  datapath-windows/ovsext/ovsext.vcxproj |   2 +
    >  23 files changed, 885 insertions(+), 105 deletions(-)  create mode 100644
    > datapath-windows/ovsext/IpFragment.c
    >  create mode 100644 datapath-windows/ovsext/IpFragment.h
    > 
    > --
    > 2.9.3.windows.1
    > 
    > _______________________________________________
    > dev mailing list
    > dev at openvswitch.org
    > https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIFAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=t5QyJn5a64GcpPiiJV4kbCdaXkse0irLvd-jujZnaf4&s=uHPLO0j8bf9tplRbI2w5Xy4s6TIg09dwgft_QY5SRuk&e= 
    



More information about the dev mailing list