[ovs-dev] [PATCH v4] ofproto-dpif: Make ofproto/trace output easier to read.

Justin Pettit jpettit at ovn.org
Thu Jan 12 21:31:43 UTC 2017


> On Jan 12, 2017, at 9:23 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Mon, Jan 09, 2017 at 08:46:28PM -0800, Justin Pettit wrote:
>> I think it would be helpful to have a comment describing this
>> function.  Also mentioning that the caller maintains ownership of
>> 'text'.
> 
> There was a lot of missing comments and documentation.  I added a bunch.
> 
>> I may be missing something, but is there anything that frees these
>> "oftrace_node"s either here or ofproto-dpif-xlate.c?
> 
> No.  Oops.  I fixed this.

You'd indicated off-list that ovn-trace probably has similar issues.  These weren't originally a problem, but it could be now that it can be run in daemon mode.  Are you planning to address that?

--Justin




More information about the dev mailing list