[ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

Yang, Yi Y yi.y.yang at intel.com
Mon Jan 16 14:26:55 UTC 2017


Hi, Eric

We hope Jiri's L3 patchset can be applied into current ovs because we and Ericsson guys are enabling packet_type support and PTAP & non-PTAP based on L3 patchset, Pravin said you're backporting your 802.1ad patches from net-next to ovs, we don't know when your patches can be posted in ovs-dev, I can help with this if you have no time.

-----Original Message-----
From: Pravin Shelar [mailto:pshelar at ovn.org] 
Sent: Monday, January 9, 2017 5:33 PM
To: Yang, Yi Y <yi.y.yang at intel.com>; Eric Garver <e at erig.me>
Cc: ovs dev <dev at openvswitch.org>; Jarno Rajahalme <jarno at ovn.org>
Subject: Re: [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

On Tue, Jan 3, 2017 at 6:47 AM, Yang, Yi Y <yi.y.yang at intel.com> wrote:
> Pravin, the issue is current ovs has too many differences from net-next tree, the best way is to apply all the patches before your patch, but it seems a super huge work, it is out of my capability :-) Anybody of you is working on this?
>

First we need to get 802.1ad patches merged in OVS out of tree module.
Eric is working on 802.1ad support to OVS. I guess he will backport these patches to out of tree kernel module along with the userspace patches. That will cover majority of the remaining changes.

Thanks,
Pravin.

> -----Original Message-----
> From: Pravin Shelar [mailto:pshelar at ovn.org]
> Sent: Sunday, January 1, 2017 3:45 PM
> To: Yang, Yi Y <yi.y.yang at intel.com>
> Cc: ovs dev <dev at openvswitch.org>; Jarno Rajahalme <jarno at ovn.org>
> Subject: Re: [PATCH v2 14/17] datapath: Fix skb->protocol for vlan 
> frames
>
> On Wed, Dec 28, 2016 at 5:56 PM, Yi Yang <yi.y.yang at intel.com> wrote:
>> Do not always set skb->protocol to be the ethertype of the L3 header.
>> For a packet with non-accelerated VLAN tags skb->protocol needs to be the ethertype of the outermost non-accelerated VLAN ethertype.
>>
>> Any VLAN offloading is undone on the OVS netlink interface, and any VLAN tags added by userspace are non-accelerated, as are double tagged VLAN packets.
>>
>> Fixes: 018c1dda5f ("openvswitch: 802.1AD Flow handling, actions, vlan 
>> parsing, netlink attributes")
>> Fixes: 5108bbaddc ("openvswitch: add processing of L3 packets")
>> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
>> Signed-off-by: Yi Yang <yi.y.yang at intel.com>
> This is not upstream patch. So even though it fixes the issue we can not apply it to out of tree kernel module.
>
> Can you look at the net branch for the correct patch.
>
> Thanks.


More information about the dev mailing list