[ovs-dev] [PATCH v2 15/17] datapath: enable vxlangpe creation in compat mode

[Yang, Yi Y]

Make sense, will change it in v3.

-----Original Message-----
From: Jiri Benc [mailto:jbenc at redhat.com] 
Sent: Wednesday, January 18, 2017 12:37 AM
To: Yang, Yi Y <yi.y.yang at intel.com>
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 15/17] datapath: enable vxlangpe creation in compat mode

On Wed, 28 Dec 2016 20:26:28 +0800, Yi Yang wrote:
> --- a/datapath/linux/compat/include/linux/openvswitch.h
> +++ b/datapath/linux/compat/include/linux/openvswitch.h
> @@ -291,6 +291,7 @@ enum ovs_vport_attr {  enum {
>  	OVS_VXLAN_EXT_UNSPEC,
>  	OVS_VXLAN_EXT_GBP,      /* Flag or __u32 */
> +	OVS_VXLAN_EXT_GPE,      /* Flag or __u32 */

Please leave several free slots between OVS_VXLAN_EXT_GBP and OVS_VXLAN_EXT_GPE. Although it's not expected that we add more values to this enum upstream, we should not rule it out completely. Having a buffer here allows to prevent nasty problems with attribute conflicts between the upstream kernel and the compat code.

 Jiri