[ovs-dev] [PATCH 1/2] libX.pc: use the correct output directory

Aaron Conole aconole at redhat.com
Thu Jan 19 14:37:45 UTC 2017

Ben Pfaff <blp at ovn.org> writes:

> On Mon, Jan 16, 2017 at 02:06:26PM -0500, Aaron Conole wrote:
>> When the ovsdb library pkgconfig changes were introduced, they placed
>> generated output in the src directory.  This is incorrect, however, as
>> the output files should actually be placed in the build directory.  It
>> is only seen when running `make distcheck` after enabling shared
>> libraries (ex: `./configure --enable-shared`).
>> Fixes: commit e72e07a97e95 ("lib: Add support for pkgconfig for libovsdb.")
>> Signed-off-by: Aaron Conole <aconole at redhat.com>
>> ---
>> RFC to patch:
>>   Introduce this after catching the error while doing some testing.
> This seems like an improvement, but is the $(builddir)/ prefix actually
> necessary?  It's unusual for this to be required.

Spot on - I should have realized it.  I'll spin a new patch and submit.

Thanks, Ben!


More information about the dev mailing list