[ovs-dev] [PATCH 05/10] actions: Add new OVN action "clone".

[Mickey Spiegel]

On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff <blp at ovn.org> wrote:

> Signed-off-by: Ben Pfaff <blp at ovn.org>
>

Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>

One comment below, found a copy/paste error in ovn-sb.xml.

---
>  include/ovn/actions.h     |  5 ++--
>  ovn/lib/actions.c         | 61 ++++++++++++++++++++++++++++++
> ++++++-----------
>  ovn/ovn-sb.xml            | 10 ++++++++
>  ovn/utilities/ovn-trace.c | 21 +++++++++++++++-
>  tests/ovn.at              |  5 ++++
>  5 files changed, 85 insertions(+), 17 deletions(-)
>

<snip>


>
> diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml
> index 5704f41..bca82e0 100644
> --- a/ovn/ovn-sb.xml
> +++ b/ovn/ovn-sb.xml
> @@ -1137,6 +1137,16 @@
>            </p>
>          </dd>
>
> +
> +        <dt><code>clone { <var>action</var>; </code>...<code>
> };</code></dt>
> +        <dd>
> +          Makes a copy of the packet being processed and executes each
> +          <code>action</code> on the copy.  Actions following the
> +          <var>arp</var> action, if any, apply to the original, unmodified
>

s/<var>arp</var>/<var>clone</var>

Mickey

+          packet.  This can be used as a way to ``save and restore'' the
> packet
> +          around a set of actions that may modify it and should not
> persist.
> +        </dd>
> +
>          <dt><code>arp { <var>action</var>; </code>...<code> };</code></dt>
>          <dd>
>            <p>
>

<snip>