[ovs-dev] [PATCH] ovs-fields: Eliminate non-ASCII characters from groff input.

Daniele Di Proietto diproiettod at ovn.org
Thu Jan 26 01:48:42 UTC 2017


2017-01-25 17:07 GMT-08:00 Ben Pfaff <blp at ovn.org>:
> It's difficult to make groff portably accept non-ASCII characters.  It's
> easier to replace them by groff escapes for the same characters, which
> this commit does.
>
> Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.")
> Signed-off-by: Ben Pfaff <blp at ovn.org>

I'm not an expert in groff, but

Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

There's an extra failure on OS X:

https://travis-ci.org/openvswitch/ovs/jobs/195350024

lib/ovs-fields.7:403: warning: macro `TQ' not defined

Not sure if it should be addressed it in this patch

Thanks

> ---
>  build-aux/extract-ofp-fields | 2 ++
>  lib/meta-flow.xml            | 3 +--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/build-aux/extract-ofp-fields b/build-aux/extract-ofp-fields
> index bc15a8b..4c92246 100755
> --- a/build-aux/extract-ofp-fields
> +++ b/build-aux/extract-ofp-fields
> @@ -752,6 +752,8 @@ ovs\-fields \- protocol header fields in OpenFlow and Open vSwitch
>          oline = oline.replace(u'\u2208', r'\[mo]')
>          oline = oline.replace(u'\u2260', r'\[!=]')
>          oline = oline.replace(u'\u2264', r'\[<=]')
> +        oline = oline.replace(u'\u2265', r'\[>=]')
> +        oline = oline.replace(u'\u00d7', r'\[mu]')
>          if len(oline):
>              output += [oline]
>
> diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml
> index 186a8db..3db0f82 100644
> --- a/lib/meta-flow.xml
> +++ b/lib/meta-flow.xml
> @@ -3102,8 +3102,7 @@ actions=clone(load:0->NXM_OF_IN_PORT[],output:123)
>
>          <dt><code>vlan_tci=0x5000/0xe000</code></dt>
>          <dd>
> -          Match packets with no 802.1Q header or tagged with prior‐
> -          ity 2 (in any VLAN).
> +          Match packets with no 802.1Q header or tagged with priority 2 (in any VLAN).
>          </dd>
>
>          <dt><code>vlan_tci=0/0xefff</code></dt>
> --
> 2.10.2
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list