[ovs-dev] [PATCH] ovs-fields: Eliminate non-ASCII characters from groff input.

Ben Pfaff blp at ovn.org
Thu Jan 26 04:31:26 UTC 2017


On Wed, Jan 25, 2017 at 05:48:42PM -0800, Daniele Di Proietto wrote:
> 2017-01-25 17:07 GMT-08:00 Ben Pfaff <blp at ovn.org>:
> > It's difficult to make groff portably accept non-ASCII characters.  It's
> > easier to replace them by groff escapes for the same characters, which
> > this commit does.
> >
> > Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.")
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> I'm not an expert in groff, but
> 
> Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

I am not an expert in groff either, but I know more about it than I want
to.

> There's an extra failure on OS X:
> 
> https://travis-ci.org/openvswitch/ovs/jobs/195350024
> 
> lib/ovs-fields.7:403: warning: macro `TQ' not defined
> 
> Not sure if it should be addressed it in this patch

Thank you, I had not noticed that yet.  I posted a separate fix.


More information about the dev mailing list