[ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

John McDowall jmcdowall at paloaltonetworks.com
Tue Jan 31 23:02:30 UTC 2017


Ah, my bad do you want me to create a single patch file?

Regards

John

On 1/31/17, 2:44 PM, "Ben Pfaff" <blp at ovn.org> wrote:

    Now that I glance at the patch titles, I guess that the problem might be
    that this patch depends on some of the later patches.  In general, each
    patch should apply, build, and test properly whether or not later
    patches have been applied.
    
    On Tue, Jan 31, 2017 at 10:03:21PM +0000, John McDowall wrote:
    > Ben,
    > 
    > Let me create a new patch set against the top of tree.
    > 
    > Regards
    > 
    > John
    > 
    > On 1/31/17, 1:46 PM, "Ben Pfaff" <blp at ovn.org> wrote:
    > 
    >     On Tue, Dec 27, 2016 at 02:11:43PM -0800, John McDowall wrote:
    >     > This is the major body of code that implements SFC. There is a new L2 stage added to
    >     > perform the chaining operations and modifications to the ACL stage to direct flows
    >     > to the service chain.
    >     > 
    >     > Co-authored-by: Flavio Fernandes <flavio at flaviof.com>
    >     > Reported at: https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddiscuss_2016-2DMarch_040381.html&d=DwIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ6VUDaavDpfOdPQrz1ED54jEjvAE36A8TVJroVlrOQ&m=0-H45ymu2qKdNfehkwCF8baQWBqDNhngIVaX4MlOpCQ&s=VbhqfPkju3uYqy7303Bfbz0fgnSeIi6aYsQoRwIH1PU&e= 
    >     > Reported at: https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddiscuss_2016-2DMay_041359.html&d=DwIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ6VUDaavDpfOdPQrz1ED54jEjvAE36A8TVJroVlrOQ&m=0-H45ymu2qKdNfehkwCF8baQWBqDNhngIVaX4MlOpCQ&s=vNieFlb8T7dsSygACJyaJiHvnrQDGCyox17covGw4Ns&e= 
    >     > 
    >     > Signed-off-by: John McDowall <jmcdowall at paloaltonetworks.com>
    >     
    >     I think that this has bit-rotted because I get tons of compiler errors
    >     trying to build it.  I tried rewinding my repo to a point from December
    >     but I still the same ones:
    >     
    >         ../ovn/northd/ovn-northd.c:2669:13: error: incomplete definition of type 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2664:18: note: forward declaration of 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2669:37: error: incomplete definition of type 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2664:18: note: forward declaration of 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2673:30: error: incomplete definition of type 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2664:18: note: forward declaration of 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2674:30: error: incomplete definition of type 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2664:18: note: forward declaration of 'struct nbrec_logical_port_pair_group'
    >         ../ovn/northd/ovn-northd.c:2701:49: error: no member named 'options' in 'struct nbrec_acl'
    >         ../ovn/northd/ovn-northd.c:2713:37: error: no member named 'n_port_chains' in 'struct nbrec_logical_switch'
    >         ../ovn/northd/ovn-northd.c:2714:30: error: no member named 'port_chains' in 'struct nbrec_logical_switch'
    >         ../ovn/northd/ovn-northd.c:2716:39: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:110:58: note: expanded from macro 'strcmp'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:111:74: note: expanded from macro 'strcmp'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:113:28: note: expanded from macro 'strcmp'
    >         /usr/include/i386-linux-gnu/bits/string2.h:53:28: note: expanded from macro '__string2_1bptr_p'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:113:28: note: expanded from macro 'strcmp'
    >         /usr/include/i386-linux-gnu/bits/string2.h:53:63: note: expanded from macro '__string2_1bptr_p'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:114:31: note: expanded from macro 'strcmp'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:117:28: note: expanded from macro 'strcmp'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:117:54: note: expanded from macro 'strcmp'
    >         /usr/include/i386-linux-gnu/bits/string2.h:53:28: note: expanded from macro '__string2_1bptr_p'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:117:54: note: expanded from macro 'strcmp'
    >         /usr/include/i386-linux-gnu/bits/string2.h:53:63: note: expanded from macro '__string2_1bptr_p'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:118:30: note: expanded from macro 'strcmp'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:119:25: note: expanded from macro 'strcmp'
    >         /usr/include/i386-linux-gnu/bits/string2.h:129:49: note: expanded from macro '__strcmp_cg'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         ../ovn/northd/ovn-northd.c:2721:44: error: incomplete definition of type 'struct nbrec_logical_port_chain'
    >         /usr/include/i386-linux-gnu/bits/string2.h:120:28: note: expanded from macro 'strcmp'
    >         ../ovn/northd/ovn-northd.c:2710:18: note: forward declaration of 'struct nbrec_logical_port_chain'
    >         fatal error: too many errors emitted, stopping now [-ferror-limit=]
    >     
    > 
    



More information about the dev mailing list