[ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

Wed Jul 5 16:10:51 UTC 2017

>From: Stokes, Ian
>Sent: Wednesday, July 5, 2017 4:48 PM
>To: Kavanagh, Mark B <mark.b.kavanagh at intel.com>; dev at openvswitch.org; Darrell
>Ball <dball at vmware.com>
>Cc: Justin Pettit <jpettit at ovn.org>
>Subject: RE: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.
>
>> >From: ovs-dev-bounces at openvswitch.org
>> >[mailto:ovs-dev-bounces at openvswitch.org]
>> >On Behalf Of Ian Stokes
>> >Sent: Tuesday, June 20, 2017 1:57 PM
>> >To: dev at openvswitch.org
>> >Subject: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.
>> >
>> >Modify docs and travis linux build script to use the DPDK 16.11.2
>> >stable branch to benefit from most recent bug fixes.
>> >
>> >Signed-off-by: Ian Stokes <ian.stokes at intel.com>
>>
>> One comment - I see references to 16.11 in $OVS_DIR/debian/changelog and
>> $OVS_DIR/rhel/openvswitch-fedora.spec.in.
>>
>> Although these weren't updated for 16.11.1, I wonder if they should have
>> been, and consequently updated here for 16.11.2?
>HI Mark,
>
>I'm not sure of those should be updated tbh, for debian it's under the header
>of
>
>openvswitch (2.7.0-1) unstable; urgency=low
>
>I think it should stay as 16.11 here as that's what was initially supported
>for 2.7.0-1 I would guess.
>
>If a new section for 2.7.1 is added I guess we could add it there (Im not sure
>though as we haven't done this before).
>
>I'd be slow to update the reference in $OVS_DIR/rhel/openvswitch-
>fedora.spec.in as its
>
>BuildRequires: dpdk-devel >= 16.11
>
>I would think the >= takes care of moving to the latest 16.11 available for
>the distro?

Sounds good - I'm no expert on distro-related matters, so this is agreeable with me.

>
>I'm not an expert on what would be required for this so happy to defer to
>other's judgments from the RHEL community.
>
>I would like to see the travis and OVS doc changes go through from the patch
>however and not be blocked by these.

Agreed. If we can agree to proceed with the patch as-is, it LGTM.

I've run the following checks, and found no issues:
- compile against DPDK v16.11.2 with gcc
- compile against DPDK v16.11.2 with clang
- static analysis with sparse
- checkpatch.py

Acked-by: Mark Kavanagh <mark.b.kavanagh at intel.com>

>
>Ian
>
>
>>
>> Thanks,
>> Mark
>>
>> >---
>> > .travis/linux-build.sh                   |    2 +-
>> > Documentation/faq/releases.rst           |    2 +-
>> > Documentation/intro/install/dpdk.rst     |    6 +++---
>> > Documentation/topics/dpdk/vhost-user.rst |    8 ++++----
>> > 4 files changed, 9 insertions(+), 9 deletions(-)
>> >
>> >diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index
>> >8750d68..f66b534 100755
>> >--- a/.travis/linux-build.sh
>> >+++ b/.travis/linux-build.sh
>> >@@ -80,7 +80,7 @@ fi
>> >
>> > if [ "$DPDK" ]; then
>> >     if [ -z "$DPDK_VER" ]; then
>> >-        DPDK_VER="16.11.1"
>> >+        DPDK_VER="16.11.2"
>> >     fi
>> >     install_dpdk $DPDK_VER
>> >     if [ "$CC" = "clang" ]; then
>> >diff --git a/Documentation/faq/releases.rst
>> >b/Documentation/faq/releases.rst index 6a53e3b..707834b 100644
>> >--- a/Documentation/faq/releases.rst
>> >+++ b/Documentation/faq/releases.rst
>> >@@ -160,7 +160,7 @@ Q: What DPDK version does each Open vSwitch release
>> >work with?
>> >     2.4.x        2.0
>> >     2.5.x        2.2
>> >     2.6.x        16.07.2
>> >-    2.7.x        16.11.1
>> >+    2.7.x        16.11.2
>> >     ============ =======
>> >
>> > Q: I get an error like this when I configure Open vSwitch:
>> >diff --git a/Documentation/intro/install/dpdk.rst
>> >b/Documentation/intro/install/dpdk.rst
>> >index e83f852..a05aa1a 100644
>> >--- a/Documentation/intro/install/dpdk.rst
>> >+++ b/Documentation/intro/install/dpdk.rst
>> >@@ -69,9 +69,9 @@ Install DPDK
>> > #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>> >
>> >        $ cd /usr/src/
>> >-       $ wget http://fast.dpdk.org/rel/dpdk-16.11.1.tar.xz
>> >-       $ tar xf dpdk-16.11.1.tar.xz
>> >-       $ export DPDK_DIR=/usr/src/dpdk-stable-16.11.1
>> >+       $ wget http://fast.dpdk.org/rel/dpdk-16.11.2.tar.xz
>> >+       $ tar xf dpdk-16.11.2.tar.xz
>> >+       $ export DPDK_DIR=/usr/src/dpdk-stable-16.11.2
>> >        $ cd $DPDK_DIR
>> >
>> > #. (Optional) Configure DPDK as a shared library diff --git
>> >a/Documentation/topics/dpdk/vhost-user.rst
>> >b/Documentation/topics/dpdk/vhost-user.rst
>> >index 6b0bf9b..e76da5f 100644
>> >--- a/Documentation/topics/dpdk/vhost-user.rst
>> >+++ b/Documentation/topics/dpdk/vhost-user.rst
>> >@@ -292,9 +292,9 @@ To begin, instantiate a guest as described in
>> >:ref:`dpdk- vhost-user` or  DPDK sources to VM and build DPDK::
>> >
>> >     $ cd /root/dpdk/
>> >-    $ wget http://fast.dpdk.org/rel/dpdk-16.11.1.tar.xz
>> >-    $ tar xf dpdk-16.11.1.tar.xz
>> >-    $ export DPDK_DIR=/root/dpdk/dpdk-stable-16.11.1
>> >+    $ wget http://fast.dpdk.org/rel/dpdk-16.11.2.tar.xz
>> >+    $ tar xf dpdk-16.11.2.tar.xz
>> >+    $ export DPDK_DIR=/root/dpdk/dpdk-stable-16.11.2
>> >     $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>> >     $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>> >     $ cd $DPDK_DIR
>> >@@ -378,7 +378,7 @@ Sample XML
>> >         </disk>
>> >         <disk type='dir' device='disk'>
>> >           <driver name='qemu' type='fat'/>
>> >-          <source dir='/usr/src/dpdk-stable-16.11.1'/>
>> >+          <source dir='/usr/src/dpdk-stable-16.11.2'/>
>> >           <target dev='vdb' bus='virtio'/>
>> >           <readonly/>
>> >         </disk>
>> >--
>> >1.7.0.7
>> >
>> >_______________________________________________
>> >dev mailing list
>> >dev at openvswitch.org
>> >https://mail.openvswitch.org/mailman/listinfo/ovs-dev