[ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

Darrell Ball dball at vmware.com
Wed Jul 5 16:47:47 UTC 2017



On 7/5/17, 8:15 AM, "Kavanagh, Mark B" <mark.b.kavanagh at intel.com> wrote:

    >From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-bounces at openvswitch.org]
    >On Behalf Of Stokes, Ian
    >Sent: Tuesday, July 4, 2017 10:09 AM
    >To: Darrell Ball <dball at vmware.com>; dev at openvswitch.org
    >Subject: Re: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.
    >
    >> Hi Ian
    >>
    >> Do you have a good link to the 16.11.2 release notes ?
    >> I have been looking around and found some links but may not be the best
    >> and I am not sure new functionality is not being enabled with 16.11.2 ?
    >>
    >> What specifically do we want from 16.11.2 ?
    >>
    >> Thanks Darrell
    >
    >Hi Darrell,
    >
    >16.11.2 will not have new functionality, it will consist of the latest bug
    >fixes for existing functionality for DPDK 16.11.1. There is no API/ABI changes
    >in the stable point releases for DPDK.
    >
    >A list of the bugs fixed in 16.11.2 since 16.11.1 is available here
    >
    >https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_doc_guides-2D16.11_rel-5Fnotes_release-5F16-5F11.html&d=DwIFAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=WT0gkeJ7w_DRRPKN4FC6Wg_G7qmoH7ZjWdDuGE9RkPQ&s=ESCIMH2vhsR-QKMN6ZZCt5cy1GPtZLi5CJHz9ACELWg&e= 
    >
    >In particular what caught my eye was the bug fixes for vfio and vhost
    >
    >vfio: fix disabling INTx
    >vfio: fix secondary process start
    >vhost: change log levels in client mode
    >vhost: fix dequeue zero copy
    >vhost: fix false sharing
    >vhost: fix fd leaks for vhost-user server mode
    >vhost: fix max queues
    >vhost: fix multiple queue not enabled for old kernels
    >vhost: fix use after free
    >
    >There is also a number of out of bound array bug fixes for the i40e and ixgbe
    >drivers.
    >
    >On a side note for the motivation for the move, there has been instances in
    >the past (for example mempool allocations) where a bug has been reported in
    >OVS DPDK in specific cornercases, upon investigating we found it was a bug in
    >DPDK 16.11.0 release which had already been reported and fixed in the 16.11.1
    >release.
    
    
    +1 on this - I've handled similar OvS 'bugs' where the root-cause was a DPDK issue that had already been resolved on the DPDK stable branch.
    I can't recommend strongly enough that we move to the 16.11.2 branch for OvS 2.7.1 (stable branch + stable branch =  fewer bugs all 'round).
    
    Thanks,
    Mark 

Hi Ian

There is no issue regarding plain bug fixes.
The only theoretical concern is enabling new code paths that were short-circuited before
because of bugs, but I don’t think that is all that common.

The link you sent is the one I was referring to but I had some doubts about the
contents so I asked to confirm. I assume the new features and API changes sections are
only related to .0 ?

If that is the case, then:
Acked-by: Darrell Ball <dlu998 at gmail.com>

Thanks Darrell





    
    >
    >As the stable releases consist of bug fixes only there should be no issue
    >pointing users to the latest stable release of the DPDK currently supported.
    >We've done this previously for OVS 2.6.x releases where we've pushed users to
    >the stable DPDK 16.07.2 release.
    >
    >Ian
    >
    >>
    >>
    >> On 7/3/17, 1:01 PM, "ovs-dev-bounces at openvswitch.org on behalf of Stokes,
    >> Ian" <ovs-dev-bounces at openvswitch.org on behalf of ian.stokes at intel.com>
    >> wrote:
    >>
    >>     Hi All,
    >>
    >>     I would like to see this go into the OVS 2.7.1 branch to ensure users
    >> are using the latest stable DPDK 16.11 release. If anyone has time to
    >> review this patch I would be grateful. I've been using 16.11.2 myself for
    >> the last number of weeks and have not encountered any issues.
    >>
    >>     Thanks
    >>     Ian
    >>
    >>     > -----Original Message-----
    >>     > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
    >>     > bounces at openvswitch.org] On Behalf Of Ian Stokes
    >>     > Sent: Tuesday, June 20, 2017 1:57 PM
    >>     > To: dev at openvswitch.org
    >>     > Subject: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.
    >>     >
    >>     > Modify docs and travis linux build script to use the DPDK 16.11.2
    >> stable
    >>     > branch to benefit from most recent bug fixes.
    >>     >
    >>     > Signed-off-by: Ian Stokes <ian.stokes at intel.com>
    >>     > ---
    >>     >  .travis/linux-build.sh                   |    2 +-
    >>     >  Documentation/faq/releases.rst           |    2 +-
    >>     >  Documentation/intro/install/dpdk.rst     |    6 +++---
    >>     >  Documentation/topics/dpdk/vhost-user.rst |    8 ++++----
    >>     >  4 files changed, 9 insertions(+), 9 deletions(-)
    >>     >
    >>     > diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index
    >>     > 8750d68..f66b534 100755
    >>     > --- a/.travis/linux-build.sh
    >>     > +++ b/.travis/linux-build.sh
    >>     > @@ -80,7 +80,7 @@ fi
    >>     >
    >>     >  if [ "$DPDK" ]; then
    >>     >      if [ -z "$DPDK_VER" ]; then
    >>     > -        DPDK_VER="16.11.1"
    >>     > +        DPDK_VER="16.11.2"
    >>     >      fi
    >>     >      install_dpdk $DPDK_VER
    >>     >      if [ "$CC" = "clang" ]; then
    >>     > diff --git a/Documentation/faq/releases.rst
    >>     > b/Documentation/faq/releases.rst index 6a53e3b..707834b 100644
    >>     > --- a/Documentation/faq/releases.rst
    >>     > +++ b/Documentation/faq/releases.rst
    >>     > @@ -160,7 +160,7 @@ Q: What DPDK version does each Open vSwitch
    >> release
    >>     > work with?
    >>     >      2.4.x        2.0
    >>     >      2.5.x        2.2
    >>     >      2.6.x        16.07.2
    >>     > -    2.7.x        16.11.1
    >>     > +    2.7.x        16.11.2
    >>     >      ============ =======
    >>     >
    >>     >  Q: I get an error like this when I configure Open vSwitch:
    >>     > diff --git a/Documentation/intro/install/dpdk.rst
    >>     > b/Documentation/intro/install/dpdk.rst
    >>     > index e83f852..a05aa1a 100644
    >>     > --- a/Documentation/intro/install/dpdk.rst
    >>     > +++ b/Documentation/intro/install/dpdk.rst
    >>     > @@ -69,9 +69,9 @@ Install DPDK
    >>     >  #. Download the `DPDK sources`_, extract the file and set
    >> ``DPDK_DIR``::
    >>     >
    >>     >         $ cd /usr/src/
    >>     > -       $ wget https://urldefense.proofpoint.com/v2/url?u=http-
    >> 3A__fast.dpdk.org_rel_dpdk-
    >> 2D16.11.1.tar.xz&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-
    >> uZnsw&m=88NoNvcZ8i84KcaxfVYNqAcbt6HZqEWwRBivO0a8ChQ&s=W-
    >> zvsIZPdDdXUqDNBAT0zYhAdY3WYLg2yTPJpUy4Uuo&e=
    >>     > -       $ tar xf dpdk-16.11.1.tar.xz
    >>     > -       $ export DPDK_DIR=/usr/src/dpdk-stable-16.11.1
    >>     > +       $ wget https://urldefense.proofpoint.com/v2/url?u=http-
    >> 3A__fast.dpdk.org_rel_dpdk-
    >> 2D16.11.2.tar.xz&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-
    >> uZnsw&m=88NoNvcZ8i84KcaxfVYNqAcbt6HZqEWwRBivO0a8ChQ&s=wbLVYNpJZGtKTloAPxp3
    >> 6_XAWi7oVNKTTb9ymPuxqoE&e=
    >>     > +       $ tar xf dpdk-16.11.2.tar.xz
    >>     > +       $ export DPDK_DIR=/usr/src/dpdk-stable-16.11.2
    >>     >         $ cd $DPDK_DIR
    >>     >
    >>     >  #. (Optional) Configure DPDK as a shared library diff --git
    >>     > a/Documentation/topics/dpdk/vhost-user.rst
    >>     > b/Documentation/topics/dpdk/vhost-user.rst
    >>     > index 6b0bf9b..e76da5f 100644
    >>     > --- a/Documentation/topics/dpdk/vhost-user.rst
    >>     > +++ b/Documentation/topics/dpdk/vhost-user.rst
    >>     > @@ -292,9 +292,9 @@ To begin, instantiate a guest as described in
    >>     > :ref:`dpdk-vhost-user` or  DPDK sources to VM and build DPDK::
    >>     >
    >>     >      $ cd /root/dpdk/
    >>     > -    $ wget https://urldefense.proofpoint.com/v2/url?u=http-
    >> 3A__fast.dpdk.org_rel_dpdk-
    >> 2D16.11.1.tar.xz&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-
    >> uZnsw&m=88NoNvcZ8i84KcaxfVYNqAcbt6HZqEWwRBivO0a8ChQ&s=W-
    >> zvsIZPdDdXUqDNBAT0zYhAdY3WYLg2yTPJpUy4Uuo&e=
    >>     > -    $ tar xf dpdk-16.11.1.tar.xz
    >>     > -    $ export DPDK_DIR=/root/dpdk/dpdk-stable-16.11.1
    >>     > +    $ wget https://urldefense.proofpoint.com/v2/url?u=http-
    >> 3A__fast.dpdk.org_rel_dpdk-
    >> 2D16.11.2.tar.xz&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-
    >> uZnsw&m=88NoNvcZ8i84KcaxfVYNqAcbt6HZqEWwRBivO0a8ChQ&s=wbLVYNpJZGtKTloAPxp3
    >> 6_XAWi7oVNKTTb9ymPuxqoE&e=
    >>     > +    $ tar xf dpdk-16.11.2.tar.xz
    >>     > +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-16.11.2
    >>     >      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
    >>     >      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
    >>     >      $ cd $DPDK_DIR
    >>     > @@ -378,7 +378,7 @@ Sample XML
    >>     >          </disk>
    >>     >          <disk type='dir' device='disk'>
    >>     >            <driver name='qemu' type='fat'/>
    >>     > -          <source dir='/usr/src/dpdk-stable-16.11.1'/>
    >>     > +          <source dir='/usr/src/dpdk-stable-16.11.2'/>
    >>     >            <target dev='vdb' bus='virtio'/>
    >>     >            <readonly/>
    >>     >          </disk>
    >>     > --
    >>     > 1.7.0.7
    >>     >
    >>     > _______________________________________________
    >>     > dev mailing list
    >>     > dev at openvswitch.org
    >>     > https://urldefense.proofpoint.com/v2/url?u=https-
    >> 3A__mail.openvswitch.org_mailman_listinfo_ovs-
    >> 2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-
    >> uZnsw&m=88NoNvcZ8i84KcaxfVYNqAcbt6HZqEWwRBivO0a8ChQ&s=L_AKvoFPHWz7QCFqbWKF
    >> dVrKLWxkFtdo6FCV5qrLROY&e=
    >>     _______________________________________________
    >>     dev mailing list
    >>     dev at openvswitch.org
    >>     https://urldefense.proofpoint.com/v2/url?u=https-
    >> 3A__mail.openvswitch.org_mailman_listinfo_ovs-
    >> 2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-
    >> uZnsw&m=88NoNvcZ8i84KcaxfVYNqAcbt6HZqEWwRBivO0a8ChQ&s=L_AKvoFPHWz7QCFqbWKF
    >> dVrKLWxkFtdo6FCV5qrLROY&e=
    >>
    >
    >_______________________________________________
    >dev mailing list
    >dev at openvswitch.org
    >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIFAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=WT0gkeJ7w_DRRPKN4FC6Wg_G7qmoH7ZjWdDuGE9RkPQ&s=t-HGsKNH8XjrqR2jnbdIQ0j0uXGrj4R_kJxTEWR4qjQ&e= 
    



More information about the dev mailing list