[ovs-dev] [PATCH v4 0/7] Packet type aware pipeline

Darrell Ball dball at vmware.com
Thu Jul 6 20:39:30 UTC 2017



On 7/6/17, 1:22 PM, "Eric Garver" <e at erig.me> wrote:

    On Thu, Jul 06, 2017 at 03:59:51PM +0000, Darrell Ball wrote:
    > Patch 4 added unit tests
    > One test was added to system userspace.
    > I ran it many times and it has never passed.
    > Is something missing in the test or supporting code ?
    
    Works for me. Maybe there is a timing problem?

Thanks
There are races in the system tests, but those tests will pass on a second attempt.
This is 100% failure.
    
    OVS: current master (fb16fec66498)

Tip of master - same for me

    Kernel: 4.12.0-rc7+

I tried 2 kernels 4.2.0 and 3.19 – always fails in both.

    OS: RHEL 7.4-ish

I really hope the distro is not relevant here
If you have reason to think so, pls speak up

    
    > 
    > ## ------------------------------ ##
    > ## openvswitch 2.7.90 test suite. ##
    > ## ------------------------------ ##
    >  94: ptap - triangle bridge setup with L2 and L3 GRE tunnels FAILED (system-userspace-packet-type-aware.at:344)
    > 
    > ## ------------- ##
    > ## Test results. ##
    > ## ------------- ##
    > 
    > ERROR: 1 test was run,
    > 1 failed unexpectedly.
    > ## ------------------------------------------- ##
    > ## system-userspace-testsuite.log was created. ##
    > ## ------------------------------------------- ##
    > 
    > Please send `tests/system-userspace-testsuite.log' and all information you think might help:
    > 
    >    To: <bugs at openvswitch.org>
    >    Subject: [openvswitch 2.7.90] system-userspace-testsuite: 94 failed
    > 
    > You may investigate any problem if you feel able to do so, in which
    > case the test suite provides a good starting point.  Its output may
    > be found below `tests/system-userspace-testsuite.dir'.
    > 
    > make: *** [check-system-userspace] Error 1
    > make: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
    > 
    > 
    > 
    > 
    > On 6/27/17, 2:29 PM, "ovs-dev-bounces at openvswitch.org on behalf of Ben Pfaff" <ovs-dev-bounces at openvswitch.org on behalf of blp at ovn.org> wrote:
    > 
    >     On Fri, Jun 23, 2017 at 04:47:48PM +0000, Zoltán Balogh wrote:
    >     > 
    >     > This series was started by Ben Pfaff, v3 can be found here:
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_778070_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=01fMZLg-sq_Rf_2X9TcxmtDN0Vx2hS2v4BABA77en0w&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_778071_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=5fpQZh33OQ_0AGjRuJNQqvS-1E6yhFoD5TxUoLayzwM&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_778076_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=rqnhEoIuJ9rECQaXZafZGrAW9us8y184GCexqK8VUxQ&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_778072_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=p5Fnh2SQ8fUrNF0V8ChNRQyQLmbjiuvKRd1UUwE93s8&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_778074_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=02CPoSKkiGGsFX4neL8TpGa75VUPaaeNYWz_2WbqBsQ&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_778073_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=eMl7m4NpJSD07nXTN_oOdQFvysmJnclSRw39GgGg9BQ&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_778075_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=71zSrD_kcUjZwuKvjfeqam_rdCpeXuxtm4TW_SsZ_3w&e= 
    >     > 
    >     > Ben's series is based on this one:
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_770490_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=W1AcbVTr4qKOBEfQuMSmVH-Illfhs0R3TYJs1s9HtfU&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_770487_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=EHhVEHj-Pvdl0I609BkK_Z44CV-641MVWlLy7rZH6Qo&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_770495_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=izZUroix8O9Bcg5XNCmvsEseCctZfho3ovxvZRz0rwI&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_770498_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=VFf2BDMVyA1OU5h0hCBJFboZtp_U2NlqmPYkLDGnWnE&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_770488_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=3_rtktraZwXdr6VkYz8ujpi_eV9MDKc8EwCDk43nnLg&e= 
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_770489_&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=1OhDZfiGpq3GF4Vie9KKwKudHEAHpG8nj8qTMqlmKV8&e= 
    >     > 
    >     > v1->v2:
    >     >   - Squash fixup patches.
    >     >   - Apply changes agreed with Jan.
    >     >   - Not yet done: Figure out whether to really show packet_type in (some)
    >     >     match_format() output.
    >     >   - New patch at the end unsuccessfully tries to re-enable packet-aware
    >     >     test.  Either I don't have enough insight yet, or it just reveals a
    >     >     bug or two.
    >     >   - 4 new patches at beginning.  First one is trivial.  Next 3 are intended
    >     >     to make it easier to debug the packet aware test that is still failing.
    >     >     Jan, you don't have to feel obligated to review these if you feel they
    >     >     are off-topic; I will get separate reviews.
    >     > 
    >     > v2->v3:
    >     >   - Drop first two patches, which have been applied to master.
    >     >   - Drop patches 3 and 4, which have been moved to a new series.
    >     >   - Drop last patch, which was incomplete.  I'll hope that Jan or Zoltan
    >     >     can pick it back up.
    >     >   - Apply Jan's and Zoltan's comments on a few other patches.
    >     > 
    >     > v3->v4:
    >     >   - Rebase to recent origin/master (0722f3410).
    >     >   - Re-introduce packet-type aware unit tests.
    >     >   - Unwildcard dl_type only for packet_type=PT_ETH.
    >     >   - Apply comments.
    >     
    >     Thanks.  I applied this series to master.
    >     _______________________________________________
    >     dev mailing list
    >     dev at openvswitch.org
    >     https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIFAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=YZOYZFR6QorkvkAZXXYPq7Z9SWuK0lZg9EH6ND2me04&s=eFnoeVgPHfExQ3X4kGuiRhqxnn-iw7rq2RoY9fvwj4I&e= 
    >     
    > 
    > _______________________________________________
    > dev mailing list
    > dev at openvswitch.org
    > https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIDAw&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=msEftCAccuIB4BWrvoXOXgDDsp7LUK5CHuIscL6JtsY&s=wbZ8iJo4O-gC9UmULTSz6NABL3Dmz-9d-Pg_28JNlmE&e= 
    



More information about the dev mailing list