[ovs-dev] flake8 checking for release branches
Ben Pfaff
blp at ovn.org
Thu Jul 6 22:12:53 UTC 2017
On Tue, May 02, 2017 at 09:58:03PM -0400, Russell Bryant wrote:
> On Mon, May 1, 2017 at 1:26 PM, Ben Pfaff <blp at ovn.org> wrote:
> > There's a bit of a problem with flake8 and release branches. The
> > release branches mainly stay the same, but flake8 marches on, and the
> > result is that building an old branch, e.g. branch-2.6, with modern
> > flake8 causes errors that break the build.
> >
> > I can think of several ways to deal with this:
>
> In OpenStack, we pin to a specific version to avoid this type of
> problem. It's not so easy to use that solution here since we're just
> using whatever version of flake8 is installed on the system.
>
> > * Do something different on master and release branches,
> > e.g. change errors to warnings when we branch for release.
> >
> > * Only make flake8 warnings into errors when configured with
> > --enable-Werror.
>
> This one sounds good to me.
OK, I sent a patch:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335025.html
I expect to backport this to any OVS version that used flake8 (2.7 and
2.6, at least).
More information about the dev
mailing list