[ovs-dev] [PATCH] tests: use full option name in bridge tests

Lance Richardson lrichard at redhat.com
Mon Jul 10 17:57:13 UTC 2017


GNU getopt_long() accepts abbreviated long option names that are
unambiguous, but other implemenations (notably musl libc) do not.

Avoid issues with non-GNU implementations by using the full option
name.

Signed-off-by: Lance Richardson <lrichard at redhat.com>
---
 tests/bridge.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/bridge.at b/tests/bridge.at
index f6c2327..8b4e4d7 100644
--- a/tests/bridge.at
+++ b/tests/bridge.at
@@ -62,7 +62,7 @@ AT_CHECK([ovs-vsctl set-fail-mode br1 secure])
 dnl Wait for the controller connectionsi to be up
 for i in `seq 0 19`
 do
-    if ovs-vsctl --column=is_connected list controller |grep "false"; then
+    if ovs-vsctl --columns=is_connected list controller |grep "false"; then
         :
     else
         break
@@ -72,7 +72,7 @@ done
 
 dnl Make sure the connection status have two records and they are different.
 dnl (The exact output contains timing information that are machine dependent.)
-AT_CHECK([ovs-vsctl --column=status list controller | dnl
+AT_CHECK([ovs-vsctl --columns=status list controller | dnl
           grep "status" | sort -u |wc -l], [0], [2
 ])
 
-- 
2.9.4



More information about the dev mailing list