[ovs-dev] [PATCH v1 3/6] ovn: extend expr symbols for ND

Ben Pfaff blp at ovn.org
Tue Jul 11 15:33:52 UTC 2017


On Tue, Jul 11, 2017 at 07:56:31PM +0530, Numan Siddique wrote:
> On Tue, Jul 11, 2017 at 2:58 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> > On Thu, Jun 15, 2017 at 02:08:39PM +0530, nusiddiq at redhat.com wrote:
> > > From: Zong Kai LI <zealokii at gmail.com>
> > >
> > > This patch updates ND symbols in logical-fields - "nd", "nd.target",
> > > "nd.sll" and "nd.tll" to describe more clear about "icmp6.type"
> > > predicate.
> > >
> > > It adds new symbols:
> > >  - "nd_rs" - to match Router Solicitation messages
> > >  - "nd_ra" - to match Router Advertisement messages
> > >
> > > Co-authored-by: Numan Siddique <nusiddiq at redhat.com>
> > > Signed-off-by: Zongkai LI <zealokii at gmail.com>
> > > Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
> >
> > Thanks for working on this.
> >
> > I'm still concerned about this from an upgrade standpoint, as I
> > explained for an earlier version:
> > https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/332104.html
> >
> > Any thoughts?
> >
> >
> Thanks for the review Ben. I totally missed your last comment. In order to
> avoid the upgrade issue, I think we need to keep the present predicates
> "nd", "nd.target", "nd.sll" and "nd.tll" AS IS and add new predicates (at
> this point I am not able to think of better names ) and then consume them
> in ovn-northd.c as you suggested in the comment.
> 
>  After looking into this patch closely, I think this patch can be dropped.
> Also the predicates "nd.target", "nd.sll" and "nd.tll" (in ovn-northd.c)
> are used always with "nd" (icmp type 135 and 136) or "nd_ns" (icmp type
> 135) in the match condition. So not sure if there is any real need to
> modify these definitions which this patch tries to do.
> 
>  To support IPv6 RA, we need to add 2 new predicates - "nd_rs" and "nd_ra"
> which I think can be added in the last patch of this series - "ovn-northd:
> Add logical flows to support native IPv6 RA".

OK, thanks for figuring it out!  I will look at the new patches.

> I will post the patches shortly dropping this patch. Please let me know if
> it makes sense to add new predicates. I can work on it as a separate patch.

If the new predicates aren't really helpful, I don't think we need them.

Thanks,

Ben.


More information about the dev mailing list