[ovs-dev] [PATCH 1/2] tc: Fix compile with Glibc < 2.24 and Linux > 4.5.

Joe Stringer joe at ovn.org
Tue Jul 11 18:33:27 UTC 2017


On 10 July 2017 at 11:28, Ben Pfaff <blp at ovn.org> wrote:
> On Mon, Jun 19, 2017 at 02:33:22PM -0700, Joe Stringer wrote:
>> linux/pkt_cls.h indirectly includes linux/stddef.h, which may define
>> __always_inline when using Linux kernel headers 4.6 or later.
>>
>> netinet/in.h indirectly includes sys/cdefs.h, which before Glibc 2.24
>> would unconditionally define __always_inline.
>>
>> This combination of headers causes compilation failure. Resolve the
>> issue by placing the netinet/in.h include above linux/pkt_cls.h.
>>
>> Sourceware-BZ: #20215.
>> Fixes: f98e418fbdb6 ("tc: Add tc flower functions")
>> Signed-off-by: Joe Stringer <joe at ovn.org>
>
> Ugh.
>
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks, this was applied to master.


More information about the dev mailing list